[PR #750] [MERGED] Fix suppressed eslint issues #1402

New issue

Closed

opened 2026-05-07 01:01:57 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:01:57 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/750
Author: @nimbleghost
Created: 5/24/2023
Status: ✅ Merged
Merged: 5/25/2023
Merged by: @binwiederhier

Base: main ← Head: web-improvements

📝 Commits (4)

9056d68 Make async for loops performant using Promise.all
4d90e32 Use es6 destructuring swap for shuffling
d178be7 Fix param reassignment issue
da17e4e Make small code style improvements

📊 Changes

6 files changed (+57 additions, -76 deletions)

View changed files

📝 web/src/app/ConnectionManager.js (+1 -3)
📝 web/src/app/Poller.js (+10 -9)
📝 web/src/app/SubscriptionManager.js (+33 -33)
📝 web/src/app/utils.js (+9 -12)
📝 web/src/components/EmojiPicker.jsx (+1 -11)
📝 web/src/components/Notifications.jsx (+3 -8)

📄 Description

I kept the changes in the eslint PR to a minimum of simple logic preserving fixes, these could potentially change/break behaviour but are likely correct. Better to review separately.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/750 **Author:** [@nimbleghost](https://github.com/nimbleghost) **Created:** 5/24/2023 **Status:** ✅ Merged **Merged:** 5/25/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `web-improvements` --- ### 📝 Commits (4) - [`9056d68`](https://github.com/binwiederhier/ntfy/commit/9056d68fc93679c288a1ca333701acc0ca674422) Make async for loops performant using Promise.all - [`4d90e32`](https://github.com/binwiederhier/ntfy/commit/4d90e32fe9f584b056fceea763aae2a39ea10396) Use es6 destructuring swap for shuffling - [`d178be7`](https://github.com/binwiederhier/ntfy/commit/d178be7576ea152386f9b41591df969eb6f18f29) Fix param reassignment issue - [`da17e4e`](https://github.com/binwiederhier/ntfy/commit/da17e4ee8a9c0c6f954a61fdab581a32fb887c1b) Make small code style improvements ### 📊 Changes **6 files changed** (+57 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `web/src/app/ConnectionManager.js` (+1 -3) 📝 `web/src/app/Poller.js` (+10 -9) 📝 `web/src/app/SubscriptionManager.js` (+33 -33) 📝 `web/src/app/utils.js` (+9 -12) 📝 `web/src/components/EmojiPicker.jsx` (+1 -11) 📝 `web/src/components/Notifications.jsx` (+3 -8) </details> ### 📄 Description I kept the changes in the eslint PR to a minimum of simple logic preserving fixes, these could potentially change/break behaviour but are _likely_ correct. Better to review separately. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>