[PR #778] [MERGED] Default installed PWA to web push enabled #1415

New issue

Closed

opened 2026-05-07 01:02:00 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:00 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/778
Author: @nimbleghost
Created: 6/24/2023
Status: ✅ Merged
Merged: 6/24/2023
Merged by: @binwiederhier

Base: main ← Head: pwa-defaults

📝 Commits (2)

dd02267 Disable PWA (manifest) when web push is disabled
48d1f78 Default web push to enabled on PWAs

📊 Changes

6 files changed (+42 additions, -12 deletions)

View changed files

📝 server/server.go (+1 -1)
📝 server/server_middleware.go (+1 -1)
📝 server/server_test.go (+23 -7)
📝 web/src/app/Prefs.js (+2 -1)
📝 web/src/app/utils.js (+13 -0)
📝 web/src/components/Preferences.jsx (+2 -2)

📄 Description

Also disable the PWA unless web push is enabled

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/778 **Author:** [@nimbleghost](https://github.com/nimbleghost) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 6/24/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `pwa-defaults` --- ### 📝 Commits (2) - [`dd02267`](https://github.com/binwiederhier/ntfy/commit/dd02267f9b3e314ed04948c24da172477af9d26a) Disable PWA (manifest) when web push is disabled - [`48d1f78`](https://github.com/binwiederhier/ntfy/commit/48d1f7887d475dae5f4e894660f5fff9b5b3afee) Default web push to enabled on PWAs ### 📊 Changes **6 files changed** (+42 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/server.go` (+1 -1) 📝 `server/server_middleware.go` (+1 -1) 📝 `server/server_test.go` (+23 -7) 📝 `web/src/app/Prefs.js` (+2 -1) 📝 `web/src/app/utils.js` (+13 -0) 📝 `web/src/components/Preferences.jsx` (+2 -2) </details> ### 📄 Description Also disable the PWA unless web push is enabled --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>