[PR #781] [MERGED] Correctly handle standalone (PWA) mode changes #1418

New issue

Closed

opened 2026-05-07 01:02:01 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:01 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/781
Author: @nimbleghost
Created: 6/25/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @binwiederhier

Base: main ← Head: refresh-pwa-state

📝 Commits (2)

a8d3297 Correctly handle standalone (PWA) mode changes
833293a Set PWA web push enabled on launch instead

📊 Changes

6 files changed (+99 additions, -84 deletions)

View changed files

📝 web/src/app/Notifier.js (+3 -8)
📝 web/src/app/Prefs.js (+1 -2)
📝 web/src/app/SubscriptionManager.js (+13 -5)
📝 web/src/app/WebPush.js (+16 -62)
📝 web/src/components/App.jsx (+2 -2)
📝 web/src/components/hooks.js (+64 -5)

📄 Description

Also handle notification permission changes
Remove web push schedule worker since this complicates things and doesn’t do that much. We have the reminder notification if the user truly doesn’t reload ntfy in more than a week AND doesn't change any topics within that period.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/781 **Author:** [@nimbleghost](https://github.com/nimbleghost) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `refresh-pwa-state` --- ### 📝 Commits (2) - [`a8d3297`](https://github.com/binwiederhier/ntfy/commit/a8d3297c4ee7c08cff1c48b8cadb98b053ce72e1) Correctly handle standalone (PWA) mode changes - [`833293a`](https://github.com/binwiederhier/ntfy/commit/833293ad77c60d74c4b7686dcdc35efa613786b6) Set PWA web push enabled on launch instead ### 📊 Changes **6 files changed** (+99 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `web/src/app/Notifier.js` (+3 -8) 📝 `web/src/app/Prefs.js` (+1 -2) 📝 `web/src/app/SubscriptionManager.js` (+13 -5) 📝 `web/src/app/WebPush.js` (+16 -62) 📝 `web/src/components/App.jsx` (+2 -2) 📝 `web/src/components/hooks.js` (+64 -5) </details> ### 📄 Description - Also handle notification permission changes - Remove web push schedule worker since this complicates things and doesn’t do _that_ much. We have the reminder notification if the user truly doesn’t reload ntfy in more than a week AND doesn't change any topics within that period. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>