[PR #791] [MERGED] Fix refreshing things when permission is granted #1425

New issue

Closed

opened 2026-05-07 01:02:02 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:02 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/791
Author: @nimbleghost
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/29/2023
Merged by: @binwiederhier

Base: main ← Head: fix-permission-handling

📝 Commits (3)

9ce3545 Fix refreshing things when permission is granted
365a0b2 Fix preferences warnings
e8216ae Fix resubscribing when notifications are re-granted

📊 Changes

8 files changed (+58 additions, -59 deletions)

View changed files

📝 web/public/static/langs/en.json (+3 -3)
📝 web/src/app/Notifier.js (+0 -3)
📝 web/src/app/SubscriptionManager.js (+5 -4)
📝 web/src/components/App.jsx (+0 -4)
📝 web/src/components/Navigation.jsx (+5 -10)
📝 web/src/components/Pref.jsx (+5 -5)
📝 web/src/components/Preferences.jsx (+5 -4)
📝 web/src/components/hooks.js (+35 -26)

📄 Description

We refreshed some things but not everything, this makes it more responsive if you have the settings page open when granting permissions, for example.

https://github.com/binwiederhier/ntfy/assets/132819643/6d609d58-c015-495d-aae1-7c2a799cb8af

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/791 **Author:** [@nimbleghost](https://github.com/nimbleghost) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/29/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `fix-permission-handling` --- ### 📝 Commits (3) - [`9ce3545`](https://github.com/binwiederhier/ntfy/commit/9ce35459015a16ff7786d9ac6926a2415de3a71a) Fix refreshing things when permission is granted - [`365a0b2`](https://github.com/binwiederhier/ntfy/commit/365a0b28323d330eae7a80131e809895df2523ac) Fix preferences warnings - [`e8216ae`](https://github.com/binwiederhier/ntfy/commit/e8216ae9e7eacdce9f84b295e3f51b13a4acb98f) Fix resubscribing when notifications are re-granted ### 📊 Changes **8 files changed** (+58 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `web/public/static/langs/en.json` (+3 -3) 📝 `web/src/app/Notifier.js` (+0 -3) 📝 `web/src/app/SubscriptionManager.js` (+5 -4) 📝 `web/src/components/App.jsx` (+0 -4) 📝 `web/src/components/Navigation.jsx` (+5 -10) 📝 `web/src/components/Pref.jsx` (+5 -5) 📝 `web/src/components/Preferences.jsx` (+5 -4) 📝 `web/src/components/hooks.js` (+35 -26) </details> ### 📄 Description We refreshed some things but not everything, this makes it more responsive if you have the settings page open when granting permissions, for example. https://github.com/binwiederhier/ntfy/assets/132819643/6d609d58-c015-495d-aae1-7c2a799cb8af --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>