[PR #812] [CLOSED] Add possibility for 'user-auth' authorization #1434

New issue

Closed

opened 2026-05-07 01:02:05 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:05 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/812
Author: @Nanowires
Created: 7/6/2023
Status: ❌ Closed

Base: main ← Head: addUserHeaderAuth

📝 Commits (2)

7126af6 Refine user header code
5f0c30a Added tests for the user-header authentication

📊 Changes

5 files changed (+122 additions, -11 deletions)

View changed files

📝 cmd/serve.go (+5 -0)
📝 server/config.go (+2 -0)
📝 server/server.go (+46 -9)
📝 server/server.yml (+14 -0)
📝 server/server_test.go (+55 -2)

📄 Description

Another PR for #601
Mostly copied from #602

Same as the original author: I'm not particularly familiar with go, or the ntfy code base, I haven't tried to run this code.

If I have time I will try to add tests in the next few days.

I'm also not sure about the way to trace here (e.g. in case that the user-header is set and the client sent one, but the user is not found)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/812 **Author:** [@Nanowires](https://github.com/Nanowires) **Created:** 7/6/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `addUserHeaderAuth` --- ### 📝 Commits (2) - [`7126af6`](https://github.com/binwiederhier/ntfy/commit/7126af6d7ca0565a2d3cd83974978d3ca99d0547) Refine user header code - [`5f0c30a`](https://github.com/binwiederhier/ntfy/commit/5f0c30a15158bad2500a0f5d565588690a05becc) Added tests for the user-header authentication ### 📊 Changes **5 files changed** (+122 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `cmd/serve.go` (+5 -0) 📝 `server/config.go` (+2 -0) 📝 `server/server.go` (+46 -9) 📝 `server/server.yml` (+14 -0) 📝 `server/server_test.go` (+55 -2) </details> ### 📄 Description Another PR for #601 Mostly copied from #602 Same as the original author: I'm not particularly familiar with go, or the ntfy code base, I haven't tried to run this code. If I have time I will try to add tests in the next few days. I'm also not sure about the way to trace here (e.g. in case that the user-header is set and the client sent one, but the user is not found) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>