[PR #820] [MERGED] fix: check extension to display external images #1437

New issue

Closed

opened 2026-05-07 01:02:06 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:06 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/820
Author: @nihalgonsalves
Created: 7/14/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @binwiederhier

Base: main ← Head: ng/display-external-images

📝 Commits (1)

384cabe feat: check extension to display external images

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 web/src/app/notificationUtils.js (+1 -1)
📝 web/src/components/Notifications.jsx (+2 -2)

📄 Description

Resolves #761, #596
Closes #763

Uses a simple extension check to avoid the erroring image problem in #763, which tries to display everything as an image. If a Notification is sent with a filename with an image extension but it isn't one, it seems like an acceptable solution to simply display an error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/820 **Author:** [@nihalgonsalves](https://github.com/nihalgonsalves) **Created:** 7/14/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `ng/display-external-images` --- ### 📝 Commits (1) - [`384cabe`](https://github.com/binwiederhier/ntfy/commit/384cabede52dc61ca57c1033bf6d4d27554d4ee2) feat: check extension to display external images ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `web/src/app/notificationUtils.js` (+1 -1) 📝 `web/src/components/Notifications.jsx` (+2 -2) </details> ### 📄 Description Resolves #761, #596 Closes #763 Uses a simple extension check to avoid the erroring image problem in #763, which tries to display _everything_ as an image. If a Notification is sent with a filename with an image extension but it isn't one, it seems like an acceptable solution to simply display an error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>