[PR #851] [MERGED] Ignore Cloudflare Priority header #1446

New issue

Closed

opened 2026-05-07 01:02:08 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:08 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/851
Author: @gusdleon
Created: 8/29/2023
Status: ✅ Merged
Merged: 9/24/2023
Merged by: @binwiederhier

Base: main ← Head: main

📝 Commits (2)

30a913c Ignore Cloudflare Priority header
85740d8 Fix cloudflarePriorityIgnore

📊 Changes

2 files changed (+23 additions, -7 deletions)

View changed files

📝 server/util.go (+23 -2)
📝 util/util.go (+0 -5)

📄 Description

Refine handling of HTTP Priority header

Part of: #351, #353, #461, ...

This PR improves the handling of the new HTTP Priority header (RFC 9218) commonly affecting ntfy instances running behind Cloudflare.

Changes:

Now if the received PUT/POST request contains the mentioned header simply ignores it and continues searching for another header or query parameter
This PR reverts some changes in 95bd876

A working instance with this fix can be tested Here
😀

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/851 **Author:** [@gusdleon](https://github.com/gusdleon) **Created:** 8/29/2023 **Status:** ✅ Merged **Merged:** 9/24/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`30a913c`](https://github.com/binwiederhier/ntfy/commit/30a913c05c3d704bd71a9658f13f3e493542f2b2) Ignore Cloudflare Priority header - [`85740d8`](https://github.com/binwiederhier/ntfy/commit/85740d810bf0f6c2e243ce70967c3a7a7981ed0c) Fix cloudflarePriorityIgnore ### 📊 Changes **2 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/util.go` (+23 -2) 📝 `util/util.go` (+0 -5) </details> ### 📄 Description # Refine handling of HTTP Priority header Part of: #351, #353, #461, ... This PR improves the handling of the new HTTP Priority header (RFC 9218) commonly affecting ntfy instances running behind Cloudflare. ## Changes: - Now if the received PUT/POST request contains the mentioned header simply ignores it and continues searching for another header or query parameter - This PR reverts some changes in 95bd876 A working instance with this fix can be tested [Here](https://ntfy.gusdleon.com/) 😀 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>