[PR #941] [MERGED] Append /v2 to module so version 2 can be used as a go package #1470

New issue

Closed

opened 2026-05-07 01:02:15 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:15 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/941
Author: @jhotmann
Created: 11/8/2023
Status: ✅ Merged
Merged: 11/17/2023
Merged by: @binwiederhier

Base: main ← Head: module-version-2

📝 Commits (1)

92cfa40 Append /v2 to module so version 2 can be used as a go package

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 go.mod (+1 -1)

📄 Description

When trying to import ntfy as a library in another go application, it defaults to the last v1 tag. When trying to import a v2 tag, the following error is thrown heckel.io/ntfy@v2.7.0: invalid version: module contains a go.mod file, so module path must match major version ("heckel.io/ntfy/v2")

This change to the go.mod allows for importing (future) v2 tags.

https://github.com/golang/go/wiki/Modules#semantic-import-versioning

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/941 **Author:** [@jhotmann](https://github.com/jhotmann) **Created:** 11/8/2023 **Status:** ✅ Merged **Merged:** 11/17/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `module-version-2` --- ### 📝 Commits (1) - [`92cfa40`](https://github.com/binwiederhier/ntfy/commit/92cfa4040b5483290a2f0abadf0226518d9e1069) Append /v2 to module so version 2 can be used as a go package ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+1 -1) </details> ### 📄 Description When trying to import ntfy as a library in another go application, it defaults to the last v1 tag. When trying to import a v2 tag, the following error is thrown `heckel.io/ntfy@v2.7.0: invalid version: module contains a go.mod file, so module path must match major version ("heckel.io/ntfy/v2")` This change to the go.mod allows for importing (future) v2 tags. https://github.com/golang/go/wiki/Modules#semantic-import-versioning --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>