[PR #1123] [MERGED] feat(server): add Cache and Firebase as keys to JSON publishing #1518

New issue

Closed

opened 2026-05-07 01:02:28 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:28 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1123
Author: @stendler
Created: 5/29/2024
Status: ✅ Merged
Merged: 5/25/2025
Merged by: @binwiederhier

Base: main ← Head: json-firebase-cache

📝 Commits (1)

5211d06 feat(server): add Cache and Firebase as keys to JSON publishing

📊 Changes

3 files changed (+53 additions, -0 deletions)

View changed files

📝 server/server.go (+6 -0)
📝 server/server_test.go (+45 -0)
📝 server/types.go (+2 -0)

📄 Description

https://github.com/binwiederhier/ntfy/issues/1119

Add Cache and Firebase as keys to JSON publishing, as they were only possible to configure via http headers before.

Added the types as strings to the publishMessage struct, as they should default to true and bools would default to false if omitted from the JSON. Alternatively, *bool could be used and require a nil check to detect omission.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1123 **Author:** [@stendler](https://github.com/stendler) **Created:** 5/29/2024 **Status:** ✅ Merged **Merged:** 5/25/2025 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `json-firebase-cache` --- ### 📝 Commits (1) - [`5211d06`](https://github.com/binwiederhier/ntfy/commit/5211d06f2cf6df049942edce655fed7fb9f94521) feat(server): add Cache and Firebase as keys to JSON publishing ### 📊 Changes **3 files changed** (+53 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/server.go` (+6 -0) 📝 `server/server_test.go` (+45 -0) 📝 `server/types.go` (+2 -0) </details> ### 📄 Description https://github.com/binwiederhier/ntfy/issues/1119 Add Cache and Firebase as keys to JSON publishing, as they were only possible to configure via http headers before. --- Added the types as strings to the publishMessage struct, as they should default to true and bools would default to false if omitted from the JSON. Alternatively, `*bool` could be used and require a nil check to detect omission. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>