[PR #1138] [MERGED] Teach ntfy webpush to write the keys to a file #1521

New issue

Closed

opened 2026-05-07 01:02:29 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:29 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1138
Author: @nogweii
Created: 6/26/2024
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @binwiederhier

Base: main ← Head: webpush-key-file

📝 Commits (3)

49a5482 teach ntfy webpush to write the keys to a file
20cca8e update go.sum
9ce6b03 Merge branch 'main' into webpush-key-file

📊 Changes

3 files changed (+30 additions, -1 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 cmd/webpush.go (+22 -1)
📝 cmd/webpush_test.go (+7 -0)

📄 Description

This does half of #1136. With just this, I can write some ansible code to read the created file and copy the values into the main config. A bit redundant, perhaps, but easily done. Adding the ability to read the file directly would be the next step.

Not super happy with the test case, but it covers the bases. A bit worried about relying on the side-effect of "the filesystem isn't broken" but that's so unusual that it's probably not worth fretting over.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1138 **Author:** [@nogweii](https://github.com/nogweii) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `webpush-key-file` --- ### 📝 Commits (3) - [`49a5482`](https://github.com/binwiederhier/ntfy/commit/49a548252c449282d8788ebf5e448f5e67b2e531) teach `ntfy webpush` to write the keys to a file - [`20cca8e`](https://github.com/binwiederhier/ntfy/commit/20cca8e88840d75e8c774bcd8033d3ed22738aaa) update go.sum - [`9ce6b03`](https://github.com/binwiederhier/ntfy/commit/9ce6b03450e1c9a14673da9c32e1b73451375ed1) Merge branch 'main' into webpush-key-file ### 📊 Changes **3 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `cmd/webpush.go` (+22 -1) 📝 `cmd/webpush_test.go` (+7 -0) </details> ### 📄 Description This does half of #1136. With just this, I can write some ansible code to read the created file and copy the values into the main config. A bit redundant, perhaps, but easily done. Adding the ability to read the file directly would be the next step. Not super happy with the test case, but it covers the bases. A bit worried about relying on the side-effect of "the filesystem isn't broken" but that's so unusual that it's probably not worth fretting over. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>