[PR #1266] [MERGED] server/util.go: fix logic in extractIPAddress() #1553

New issue

Closed

opened 2026-05-07 01:02:38 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:38 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1266
Author: @mmatuska
Created: 1/25/2025
Status: ✅ Merged
Merged: 5/21/2025
Merged by: @binwiederhier

Base: main ← Head: fix/extractIPAddress

📝 Commits (1)

bd39cf4 server/util.go: fix logic in extractIPAddress()

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/util.go (+1 -1)

📄 Description

The error message "unable to parse IP" in extractIPAddress() of server/util.go should be displayed when remoteAddr is not "@" (unix socket) AND behind-proxy is not true.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1266 **Author:** [@mmatuska](https://github.com/mmatuska) **Created:** 1/25/2025 **Status:** ✅ Merged **Merged:** 5/21/2025 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `fix/extractIPAddress` --- ### 📝 Commits (1) - [`bd39cf4`](https://github.com/binwiederhier/ntfy/commit/bd39cf4b54f1959808b6416266ea94ee42b9d95e) server/util.go: fix logic in extractIPAddress() ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/util.go` (+1 -1) </details> ### 📄 Description The error message "unable to parse IP" in extractIPAddress() of server/util.go should be displayed when remoteAddr is not "@" (unix socket) AND behind-proxy is not true. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>