[PR #1287] [MERGED] Handle anonymous read restrictions by sending a poll_request event #1559

Closed
opened 2026-05-07 01:02:40 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1287
Author: @barart
Created: 3/5/2025
Status: Merged
Merged: 5/23/2025
Merged by: @binwiederhier

Base: mainHead: fix-anonymous-read-restriction


📝 Commits (1)

  • 6b2cfb1 Handle anonymous read restrictions by sending a poll_request event

📊 Changes

1 file changed (+30 additions, -8 deletions)

View changed files

📝 server/server_firebase.go (+30 -8)

📄 Description

If a topic does not allow anonymous reads, this change ensures that we send a "poll_request" event instead of relaying the message via Firebase. Additionally, we include generic text in the title and body/message. This way, if the client cannot retrieve the actual message, the user will still receive a notification, prompting them to update the client manually.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1287 **Author:** [@barart](https://github.com/barart) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 5/23/2025 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `fix-anonymous-read-restriction` --- ### 📝 Commits (1) - [`6b2cfb1`](https://github.com/binwiederhier/ntfy/commit/6b2cfb1d1d76a58629d205883924c6655e10cd3e) Handle anonymous read restrictions by sending a poll_request event ### 📊 Changes **1 file changed** (+30 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `server/server_firebase.go` (+30 -8) </details> ### 📄 Description If a topic does not allow anonymous reads, this change ensures that we send a "poll_request" event instead of relaying the message via Firebase. Additionally, we include generic text in the title and body/message. This way, if the client cannot retrieve the actual message, the user will still receive a notification, prompting them to update the client manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 01:02:40 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ntfy#1559
No description provided.