mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[PR #1287] [MERGED] Handle anonymous read restrictions by sending a poll_request event #1559
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#1559
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/binwiederhier/ntfy/pull/1287
Author: @barart
Created: 3/5/2025
Status: ✅ Merged
Merged: 5/23/2025
Merged by: @binwiederhier
Base:
main← Head:fix-anonymous-read-restriction📝 Commits (1)
6b2cfb1Handle anonymous read restrictions by sending a poll_request event📊 Changes
1 file changed (+30 additions, -8 deletions)
View changed files
📝
server/server_firebase.go(+30 -8)📄 Description
If a topic does not allow anonymous reads, this change ensures that we send a "poll_request" event instead of relaying the message via Firebase. Additionally, we include generic text in the title and body/message. This way, if the client cannot retrieve the actual message, the user will still receive a notification, prompting them to update the client manually.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.