[PR #1495] [CLOSED] enable pwa share target #1619

New issue

Closed

opened 2026-05-07 01:02:56 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:56 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1495
Author: @nexus-uw
Created: 11/22/2025
Status: ❌ Closed

Base: main ← Head: share-target

📝 Commits (1)

36e26ff enable pwa share target

📊 Changes

8 files changed (+106 additions, -4 deletions)

View changed files

📝 Makefile (+1 -1)
📝 server/server.go (+10 -0)
📝 server/types.go (+15 -0)
📝 web/package.json (+1 -1)
📝 web/public/sw.js (+34 -0)
📝 web/src/components/App.jsx (+30 -1)
📝 web/src/components/Messaging.jsx (+3 -1)
📝 web/src/components/PublishDialog.jsx (+12 -0)

📄 Description

adds share_target property to manifest with title + text + url
configure to send POST to new url , /share-target
- going with POST so that files can be shared in the future -> https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/share_target#receiving_shared_files
updated webworker to intercept fetch requests, and redirect+restructure /share-target requests to SPA page with parameters moved to the url params

(mostly generated by gpt5 using
"i want to add a pwa share target that invokes the publish message button on the web app")

note: I am unable to currently build the docker container to fully test the e2e flow due to

25.40 cmd/serve.go:22:2: no required module provides package heckel.io/ntfy/v2/payments; to add it:
25.40   go get heckel.io/ntfy/v2/payments
25.42 make: *** [Makefile:188: cli-linux-server] Error 1
------

 1 warning found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
Dockerfile-build:43
--------------------
  41 |     ADD ./user ./user
  42 |     ADD ./util ./util
  43 | >>> RUN make VERSION=$VERSION COMMIT=$COMMIT cli-linux-server

running the web client with the npm start command, I was able to verify that url params are successfully read from the url and the publish message opened with the expected values.

what would be the best test command(s) to get the server + web assets deployed locally together?

implements https://github.com/binwiederhier/ntfy/issues/1423

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1495 **Author:** [@nexus-uw](https://github.com/nexus-uw) **Created:** 11/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `share-target` --- ### 📝 Commits (1) - [`36e26ff`](https://github.com/binwiederhier/ntfy/commit/36e26ff72370572f47405481648fa8ddd8718fd6) enable pwa share target ### 📊 Changes **8 files changed** (+106 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) 📝 `server/server.go` (+10 -0) 📝 `server/types.go` (+15 -0) 📝 `web/package.json` (+1 -1) 📝 `web/public/sw.js` (+34 -0) 📝 `web/src/components/App.jsx` (+30 -1) 📝 `web/src/components/Messaging.jsx` (+3 -1) 📝 `web/src/components/PublishDialog.jsx` (+12 -0) </details> ### 📄 Description - adds share_target property to manifest with title + text + url - configure to send POST to new url , /share-target - going with POST so that files can be shared in the future -> https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/share_target#receiving_shared_files - updated webworker to intercept fetch requests, and redirect+restructure /share-target requests to SPA page with parameters moved to the url params (mostly generated by gpt5 using "i want to add a pwa share target that invokes the publish message button on the web app") note: I am unable to currently build the docker container to fully test the e2e flow due to ```` 25.40 cmd/serve.go:22:2: no required module provides package heckel.io/ntfy/v2/payments; to add it: 25.40 go get heckel.io/ntfy/v2/payments 25.42 make: *** [Makefile:188: cli-linux-server] Error 1 ------ 1 warning found (use docker --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) Dockerfile-build:43 -------------------- 41 | ADD ./user ./user 42 | ADD ./util ./util 43 | >>> RUN make VERSION=$VERSION COMMIT=$COMMIT cli-linux-server ```` running the web client with the npm start command, I was able to verify that url params are successfully read from the url and the publish message opened with the expected values. what would be the best test command(s) to get the server + web assets deployed locally together? implements https://github.com/binwiederhier/ntfy/issues/1423 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>