[PR #1501] [MERGED] do not build fbsend with nofirebase #1623

New issue

Closed

opened 2026-05-07 01:02:57 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:57 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1501
Author: @aerusso
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/24/2025
Merged by: @binwiederhier

Base: main ← Head: mrs/nofirebase-fbsend

📝 Commits (1)

693d2d6 do not build fbsend with nofirebase

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 tools/fbsend/main.go (+2 -0)

📄 Description

The nofirebase build tag should remove all build dependencies on firebase. The fbsend test tool depends on firebase (and is also only useful in builds that use firebase). Hence, disable it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1501 **Author:** [@aerusso](https://github.com/aerusso) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/24/2025 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `mrs/nofirebase-fbsend` --- ### 📝 Commits (1) - [`693d2d6`](https://github.com/binwiederhier/ntfy/commit/693d2d630f1439b14595b04960dd3a9b6212e62c) do not build fbsend with nofirebase ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tools/fbsend/main.go` (+2 -0) </details> ### 📄 Description The nofirebase build tag should remove all build dependencies on firebase. The fbsend test tool depends on firebase (and is also only useful in builds that use firebase). Hence, disable it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>