[PR #1530] Added support for LOGIN AUTH for the SMTP sender #1630

New issue

Open

opened 2026-05-07 01:02:59 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:02:59 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1530
Author: @santanoce
Created: 1/1/2026
Status: 🔄 Open

Base: main ← Head: feat/login_auth

📝 Commits (3)

0527f13 feat: added support for LOGIN AUTH for the SMTP sender
8e6c2a2 refactor: improved log from byte to string
c1fa107 Merge branch 'main' into feat/login_auth

📊 Changes

2 files changed (+73 additions, -1 deletions)

View changed files

📝 docs/config.md (+1 -1)
📝 server/smtp_sender.go (+72 -0)

📄 Description

This should fix #1020, even though it seems that Microsoft 365 Outlook is no longer allowing base authentication for personal accounts, so I wasn't able to actually test it with a Microsoft account. I did however test it using a simple SMTP server supporting LOGIN AUTH and it works.

I basically followed the suggestion in #930, more specifically using the code from here, which in turn is an adaptation of code in the net/smtp package.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1530 **Author:** [@santanoce](https://github.com/santanoce) **Created:** 1/1/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/login_auth` --- ### 📝 Commits (3) - [`0527f13`](https://github.com/binwiederhier/ntfy/commit/0527f139de4bdbdab9384f0014bbaeffe6b70ced) feat: added support for LOGIN AUTH for the SMTP sender - [`8e6c2a2`](https://github.com/binwiederhier/ntfy/commit/8e6c2a2087dda829b6b1e67107029bd3989cd948) refactor: improved log from byte to string - [`c1fa107`](https://github.com/binwiederhier/ntfy/commit/c1fa107f6da0d1023113aca80f64678565a83496) Merge branch 'main' into feat/login_auth ### 📊 Changes **2 files changed** (+73 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+1 -1) 📝 `server/smtp_sender.go` (+72 -0) </details> ### 📄 Description This should fix #1020, even though it seems that Microsoft 365 Outlook is no longer allowing base authentication for personal accounts, so I wasn't able to actually test it with a Microsoft account. I did however test it using a simple SMTP server supporting LOGIN AUTH and it works. I basically followed the suggestion in #930, more specifically using the code from [here](https://gist.github.com/andelf/5118732?permalink_comment_id=4825669#gistcomment-4825669), which in turn is an adaptation of code in the [net/smtp package](https://cs.opensource.google/go/go/+/master:src/net/smtp/auth.go). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>