[PR #1603] [MERGED] Allow overriding npm binary in Makefile #1657

Closed
opened 2026-05-07 01:03:06 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1603
Author: @cyqsimon
Created: 2/12/2026
Status: Merged
Merged: 2/13/2026
Merged by: @binwiederhier

Base: mainHead: npm-override


📝 Commits (1)

  • bc08819 Allow overriding npm binary in Makefile

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 Makefile (+7 -6)

📄 Description

Similar to #949.

I've noticed that Fedora sometimes ship the npm binary under versioned names, most recently here (archive). In Fedora 44 (pre-release) as of time of writing, the nodejs-npm package is an alias of nodejs22-npm, which installs npm as /usr/bin/npm-22.

Anyways, it would be nice if such cases can be dealt with easily.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1603 **Author:** [@cyqsimon](https://github.com/cyqsimon) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `npm-override` --- ### 📝 Commits (1) - [`bc08819`](https://github.com/binwiederhier/ntfy/commit/bc08819525628aa82557392014fc2d02b711a11b) Allow overriding `npm` binary in Makefile ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+7 -6) </details> ### 📄 Description Similar to #949. I've noticed that Fedora sometimes ship the `npm` binary under versioned names, most recently [here](https://download.copr.fedorainfracloud.org/results/cyqsimon/ntfysh/fedora-44-aarch64/10118658-ntfysh/builder-live.log) ([archive](https://web.archive.org/web/20260212100022/https://download.copr.fedorainfracloud.org/results/cyqsimon/ntfysh/fedora-44-aarch64/10118658-ntfysh/builder-live.log)). In Fedora 44 (pre-release) as of time of writing, the `nodejs-npm` package is an alias of `nodejs22-npm`, which installs `npm` as `/usr/bin/npm-22`. Anyways, it would be nice if such cases can be dealt with easily. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 01:03:06 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ntfy#1657
No description provided.