[PR #1670] [MERGED] build: fix Dockerfile-build, bump EoL go/node #1685

New issue

Closed

opened 2026-05-07 01:03:14 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:03:14 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1670
Author: @nihalgonsalves
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/22/2026
Merged by: @binwiederhier

Base: main ← Head: ng/fix-dockerfile-build

📝 Commits (2)

52cad20 build: fix Dockerfile-build, bump EoL go/node
d5466f3 perf: speed up deps using buildkit cache

📊 Changes

5 files changed (+15 additions, -29 deletions)

View changed files

📝 .github/workflows/build.yaml (+2 -2)
📝 .github/workflows/release.yaml (+2 -2)
📝 .github/workflows/test.yaml (+2 -2)
📝 Dockerfile-build (+9 -5)
📝 web/package-lock.json (+0 -18)

📄 Description

Dockerfile-build was failing because of multiple issues:

mismatch between container and go.mod version

 ```
 0.469 go: go.mod requires go >= 1.25.0 (running go 1.24.6; GOTOOLCHAIN=local)
 0.473 make: *** [Makefile:191: cli-linux-server] Error 1
 ------
 [+] build 0/1
  ⠙ Image ntfy Building
 Dockerfile-build:44

 --------------------

   42 |     ADD ./util ./util

   43 |     ADD ./payments ./payments

   44 | >>> RUN make VERSION=$VERSION COMMIT=$COMMIT cli-linux-server

   45 |     

   46 |     FROM alpine

 --------------------
 ```

Missing packages:

 ```
 18.96 cmd/user.go:14:2: no required module provides package heckel.io/ntfy/v2/db; to add it:
 18.96   go get heckel.io/ntfy/v2/db
 18.96 cmd/user.go:15:2: no required module provides package heckel.io/ntfy/v2/db/pg; to add it:
 18.96   go get heckel.io/ntfy/v2/db/pg
 18.96 server/server.go:38:2: no required module provides package heckel.io/ntfy/v2/message; to add it:
 18.96   go get heckel.io/ntfy/v2/message
 18.96 server/actions.go:11:2: no required module provides package heckel.io/ntfy/v2/model; to add it:
 18.96   go get heckel.io/ntfy/v2/model
 18.96 server/server.go:44:2: no required module provides package heckel.io/ntfy/v2/webpush; to add it:
 18.96   go get heckel.io/ntfy/v2/webpush
 18.97 make: *** [Makefile:191: cli-linux-server] Error 1
 ```

I bumped go to match the go.mod bump from fb26e7ef3a
I switched to Debian stable (bookworm)
I bumped the EoL node version to current LTS (24)
I updated some GitHub Actions that also referenced all these old values

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1670 **Author:** [@nihalgonsalves](https://github.com/nihalgonsalves) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/22/2026 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `ng/fix-dockerfile-build` --- ### 📝 Commits (2) - [`52cad20`](https://github.com/binwiederhier/ntfy/commit/52cad203fa0fce3b2383227c1904c067b2023d9c) build: fix Dockerfile-build, bump EoL go/node - [`d5466f3`](https://github.com/binwiederhier/ntfy/commit/d5466f30e5e0eb8b68aca979d77f62038ea832ca) perf: speed up deps using buildkit cache ### 📊 Changes **5 files changed** (+15 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yaml` (+2 -2) 📝 `.github/workflows/release.yaml` (+2 -2) 📝 `.github/workflows/test.yaml` (+2 -2) 📝 `Dockerfile-build` (+9 -5) 📝 `web/package-lock.json` (+0 -18) </details> ### 📄 Description `Dockerfile-build` was failing because of multiple issues: 1. mismatch between container and `go.mod` version ``` 0.469 go: go.mod requires go >= 1.25.0 (running go 1.24.6; GOTOOLCHAIN=local) 0.473 make: *** [Makefile:191: cli-linux-server] Error 1 ------ [+] build 0/1 ⠙ Image ntfy Building Dockerfile-build:44 -------------------- 42 | ADD ./util ./util 43 | ADD ./payments ./payments 44 | >>> RUN make VERSION=$VERSION COMMIT=$COMMIT cli-linux-server 45 | 46 | FROM alpine -------------------- ``` 2. Missing packages: ``` 18.96 cmd/user.go:14:2: no required module provides package heckel.io/ntfy/v2/db; to add it: 18.96 go get heckel.io/ntfy/v2/db 18.96 cmd/user.go:15:2: no required module provides package heckel.io/ntfy/v2/db/pg; to add it: 18.96 go get heckel.io/ntfy/v2/db/pg 18.96 server/server.go:38:2: no required module provides package heckel.io/ntfy/v2/message; to add it: 18.96 go get heckel.io/ntfy/v2/message 18.96 server/actions.go:11:2: no required module provides package heckel.io/ntfy/v2/model; to add it: 18.96 go get heckel.io/ntfy/v2/model 18.96 server/server.go:44:2: no required module provides package heckel.io/ntfy/v2/webpush; to add it: 18.96 go get heckel.io/ntfy/v2/webpush 18.97 make: *** [Makefile:191: cli-linux-server] Error 1 ``` --- - I bumped go to match the go.mod bump from fb26e7ef3a246273a5d9c5574f2418c4fbbdbbdd - I switched to Debian stable (bookworm) - I bumped the EoL node version to current LTS (24) - I updated some GitHub Actions that also referenced all these old values --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>