mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #255] YAML variables shouldn't use dashes #201
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#201
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ajdelgado on GitHub (May 15, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/255
Hi,
The YAML specification defines a dash as a special character and can't be used for variables. This makes the configuration file for ntfy not complaint causing first an issue to check correct syntax but in my case an issue creating an Ansible Role. what could be a simple YAML2YAML process needs translation to set the dashes.
I guess the easier solution for the community would be allowing defining with dashes or underscores for a while, and deprecating the dashes at some point.
Maybe this should be a new feature request, but it actually breaks tests.
@binwiederhier commented on GitHub (May 16, 2022):
Thank you for using ntfy and for reporting this. Well that's a bummer with the config options. I'm using the urfave/cli library and it does all the config loading for me. It's using the config options as CLI options and config file options, which is why _ are kind of ugly. Maybe I could just make it support both. Aliases are already supported by the library. Could be a super simple ticket.
In the meantime, you could probably use environment variables in Ansible, no?
@binwiederhier commented on GitHub (May 16, 2022):
Reference: https://github.com/binwiederhier/ntfy/blob/main/cmd/serve_linux.go#L22
@binwiederhier commented on GitHub (May 16, 2022):
This is done in
github.com/binwiederhier/ntfy@91594faf28and will be in the next release. Thank you for reporting @ajdelgado.