mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #314] Add server version to web ui #246
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#246
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @poblabs on GitHub (Jun 6, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/314
I had a thought today that it may be a good idea to show the server version somewhere. Maybe on the sidebar of the web ui?
@binwiederhier commented on GitHub (Jun 7, 2022):
This is typically bad security practice, because in case there are security vulnerabilities, it makes it easy for an attacker to find vulnerable instances. What is the actual reasoning behind this? You want to make sure you're up to date? In that case, maybe set up
unattended-upgradesor something similar for Docker?@poblabs commented on GitHub (Jun 8, 2022):
Good point and I had considered that before submitting the ticket. Yes just
a reference to always stay up to date. I'm currently not running this in
docker but rather as the standalone binary. Would it be possible maybe to
put the version once the binary starts up on console?
If not no worries.
On Tue, Jun 7, 2022, 7:44 PM Philipp C. Heckel @.***>
wrote:
@Mikaela commented on GitHub (Jun 8, 2022):
I am not sure security by obscurity is that great practice and it may make clientside debugging/troublesholting more difficult if e.g. third party server by a friend gets used.
@binwiederhier commented on GitHub (Jun 8, 2022):
It is best practice and part of layered security. Apache and nginx and all the others have settings to hide the version number in their response headers.
I think @poblabs's problem is a different one and has been solved by packages (rpm/deb) or docker.
If y'all really feel strongly I can add it and make it configurable, but I don't really think it's necessary.
Adding it to the
ntfy serveoutput though is not a problem.https://nginx.org/en/docs/http/ngx_http_core_module.html#server_tokens
https://httpd.apache.org/docs/2.4/mod/core.html#servertokens
@poblabs commented on GitHub (Jun 8, 2022):
Adding it to ntfy serve console output would work just fine. Thanks!
On Wed, Jun 8, 2022, 6:44 AM Philipp C. Heckel @.***>
wrote:
@binwiederhier commented on GitHub (Jun 12, 2022):
Done as part of
github.com/binwiederhier/ntfy@cf0f002bfa