starred/ntfy

Fork 0

mirror of https://github.com/binwiederhier/ntfy.git synced 2026-05-09 16:35:53 +02:00

[GH-ISSUE #488] migrate to modernc.org/sqlite #373

New issue

Closed

opened 2026-05-07 00:23:37 +02:00 by BreizhHardware · 4 comments

BreizhHardware commented

2026-05-07 00:23:37 +02:00

Owner

Originally created by @sbinet on GitHub (Nov 12, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/488

hi there,

any reason why ntfy doesn't use modernc.org/sqlite which is a pure-Go implementation of sqlite3 ?
this would ease the cross-compilation story (ex: amd64 -> arm64) and make the binary pure-Go (and more easily statically compiled)

Originally created by @sbinet on GitHub (Nov 12, 2022). Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/488 hi there, any reason why `ntfy` doesn't use [modernc.org/sqlite](https://modernc.org/sqlite) which is a pure-Go implementation of `sqlite3` ? this would ease the cross-compilation story (ex: amd64 -> arm64) and make the binary pure-Go (and more easily statically compiled)

BreizhHardware

2026-05-07 00:23:37 +02:00

closed this issue
added the
server

enhancement
labels

BreizhHardware commented

2026-05-07 00:23:38 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 12, 2022):

This is certainly intriguing. Do you have any information around the maturity, compatibility or the performance of this implementation?

Specifically

Is armv6, armv7 and arm64 supported?
Is WAL mode supported?
How mature/stable is the implementation?

@binwiederhier commented on GitHub (Nov 12, 2022): This is certainly intriguing. Do you have any information around the maturity, compatibility or the performance of this implementation? Specifically - Is armv6, armv7 and arm64 supported? - Is WAL mode supported? - How mature/stable is the implementation?

BreizhHardware commented

2026-05-07 00:23:38 +02:00

Author

Owner

@sbinet commented on GitHub (Nov 12, 2022):

AFAIK, it's a mechanically translated C-to-Go version from the official sqlite3 project.

as for the architectures supported:

https://pkg.go.dev/modernc.org/sqlite#hdr-Supported_platforms_and_architectures

I don't have performances numbers wrt mattn/go-sqlite3.
perkeep has switched to modernc.org/sqlite some time ago.

are there tests in ntfy that exercize WAL ?
(running go test ./... fails for me, with and w/o modernc.org/sqlite)

@sbinet commented on GitHub (Nov 12, 2022): AFAIK, it's a mechanically translated C-to-Go version from the official sqlite3 project. as for the architectures supported: - https://pkg.go.dev/modernc.org/sqlite#hdr-Supported_platforms_and_architectures I don't have performances numbers _wrt_ `mattn/go-sqlite3`. [perkeep](https://perkeep.org) has switched to `modernc.org/sqlite` some time ago. are there tests in `ntfy` that exercize WAL ? (running `go test ./...` fails for me, with and w/o `modernc.org/sqlite`)

BreizhHardware commented

2026-05-07 00:23:38 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 13, 2022):

AFAIK, it's a mechanically translated C-to-Go version from the official sqlite3 project.

Fascinating. But also terrifying.

are there tests in ntfy that exercize WAL ?

There are no tests that use the WAL. In fact, it's not used by default at all. But it can be enabled like this: https://ntfy.sh/docs/config/#wal-for-message-cache (which is done for ntfy.sh to speed up cache writes).

(running go test ./... fails for me, with and w/o modernc.org/sqlite)

Can you share what fails? Maybe use the make test target (though that's almost the same)

@binwiederhier commented on GitHub (Nov 13, 2022): > AFAIK, it's a mechanically translated C-to-Go version from the official sqlite3 project. Fascinating. But also terrifying. > are there tests in `ntfy` that exercize WAL ? There are no tests that use the WAL. In fact, it's not used by default at all. But it can be enabled like this: https://ntfy.sh/docs/config/#wal-for-message-cache (which is done for ntfy.sh to speed up cache writes). > (running `go test ./...` fails for me, with and w/o `modernc.org/sqlite`) Can you share what fails? Maybe use the `make test` target (though that's almost the same)

BreizhHardware commented

2026-05-07 00:23:38 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 16, 2022):

Given my recent issues with SQLite (see #498), I think I'll still with the real deal for now.
I'll definitely keep this in mind. It would make things much easier indeed.

Let me know if you get it to compile.

@binwiederhier commented on GitHub (Nov 16, 2022): Given my recent issues with SQLite (see #498), I think I'll still with the real deal for now. I'll definitely keep this in mind. It would make things much easier indeed. Let me know if you get it to compile.

BreizhHardware referenced this issue

2026-05-07 01:01:23 +02:00

[PR #373] [MERGED] Move COMMIT into a variable so it could be overridden if desired #1286