starred/ntfy

Fork 0

mirror of https://github.com/binwiederhier/ntfy.git synced 2026-05-09 08:26:00 +02:00

[GH-ISSUE #503] Sender column in cache.db shows `invalid IP` #382

New issue

Closed

opened 2026-05-07 00:23:41 +02:00 by BreizhHardware · 9 comments

BreizhHardware commented

2026-05-07 00:23:41 +02:00

Owner

Originally created by @binwiederhier on GitHub (Nov 16, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/503

sqlite> select * from messages limit 10
   ...> ;
247|OIvQ1dqYzCYP|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
248|yRmpGNK6Rtnr|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
249|CYfstoAzWhx6|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
250|9bqeSW4eQwL2|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
251|M6jJkh3UpIWo|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
252|EI39IZaXIH3Z|1668540105|aa|triggered||0||||||0|0||invalid IP||1|
253|h8lqfzT4xtrx|1668540106|aa|triggered||0||||||0|0||invalid IP||1|
254|vDrRlh3DdiJx|1668540155|aa|triggered||0||||||0|0||invalid IP||1|
255|SoomY2DjlmXU|1668540155|aa|triggered||0||||||0|0||invalid IP||1|
256|oueH0BOGr0tm|1668540155|aa|triggered||0||||||0|0||invalid IP||1|

Originally created by @binwiederhier on GitHub (Nov 16, 2022). Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/503 ``` sqlite> select * from messages limit 10 ...> ; 247|OIvQ1dqYzCYP|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 248|yRmpGNK6Rtnr|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 249|CYfstoAzWhx6|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 250|9bqeSW4eQwL2|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 251|M6jJkh3UpIWo|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 252|EI39IZaXIH3Z|1668540105|aa|triggered||0||||||0|0||invalid IP||1| 253|h8lqfzT4xtrx|1668540106|aa|triggered||0||||||0|0||invalid IP||1| 254|vDrRlh3DdiJx|1668540155|aa|triggered||0||||||0|0||invalid IP||1| 255|SoomY2DjlmXU|1668540155|aa|triggered||0||||||0|0||invalid IP||1| 256|oueH0BOGr0tm|1668540155|aa|triggered||0||||||0|0||invalid IP||1| ```

BreizhHardware

2026-05-07 00:23:41 +02:00

closed this issue
added the
🪲 bug

server
labels

BreizhHardware commented

2026-05-07 00:23:41 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 16, 2022):

Likely related to the work in #429
/cc @karmanyaahm

@binwiederhier commented on GitHub (Nov 16, 2022): Likely related to the work in #429 /cc @karmanyaahm

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@karmanyaahm commented on GitHub (Nov 16, 2022):

I'll see what I can find

@karmanyaahm commented on GitHub (Nov 16, 2022): I'll see what I can find

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@karmanyaahm commented on GitHub (Nov 17, 2022):

Are there any patterns (to help me reproduce this)? Is it happening often or rarely; for any content or just "triggered"; with no attachments?

@karmanyaahm commented on GitHub (Nov 17, 2022): Are there any patterns (to help me reproduce this)? Is it happening often or rarely; for any content or just "triggered"; with no attachments?

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 17, 2022):

sqlite> select count(*) from messages where sender='invalid IP';
count(*)  
----------
137932    
       
sqlite> select count(*) from messages where sender<>'invalid IP';
count(*)  
----------
1239

Pretty much all messages have this. I may have time to look tonight a little.

@binwiederhier commented on GitHub (Nov 17, 2022): ``` sqlite> select count(*) from messages where sender='invalid IP'; count(*) ---------- 137932 sqlite> select count(*) from messages where sender<>'invalid IP'; count(*) ---------- 1239 ``` Pretty much all messages have this. I may have time to look tonight a little.

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 17, 2022):

It is worth noting that I'm behind nginx with the config mentioned here: https://docs.ntfy.sh/config/#nginxapache2caddy
Maybe an issue with X-Forwarded-For parsing?

@binwiederhier commented on GitHub (Nov 17, 2022): It is worth noting that I'm behind nginx with the config mentioned here: https://docs.ntfy.sh/config/#nginxapache2caddy Maybe an issue with X-Forwarded-For parsing?

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@karmanyaahm commented on GitHub (Nov 17, 2022):

I only ever tested with Caddy, so that might be it, I"ll try setting up nginx.

@karmanyaahm commented on GitHub (Nov 17, 2022): I only ever tested with Caddy, so that might be it, I"ll try setting up nginx.

BreizhHardware commented

2026-05-07 00:23:42 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 17, 2022):

Don't worry about it. I can probably figure it out. Unless you're eager to learn nginx hehe

@binwiederhier commented on GitHub (Nov 17, 2022): Don't worry about it. I can probably figure it out. Unless you're eager to learn nginx hehe

BreizhHardware commented

2026-05-07 00:23:43 +02:00

Author

Owner

@binwiederhier commented on GitHub (Nov 18, 2022):

https://pkg.go.dev/net/netip#Addr.String

String returns the string form of the IP address ip. It returns one of 5 forms:

"invalid IP", if ip is the zero Addr
...

@binwiederhier commented on GitHub (Nov 18, 2022): https://pkg.go.dev/net/netip#Addr.String > String returns the string form of the IP address ip. It returns one of 5 forms: > - "invalid IP", if ip is the zero Addr > ...

BreizhHardware commented

2026-05-07 00:23:43 +02:00

Author

Owner

@karmanyaahm commented on GitHub (Nov 24, 2022):

Interesting ... so I should've set the 'invalid IP's to empty strings, and validated them at parse time.

@karmanyaahm commented on GitHub (Nov 24, 2022): Interesting ... so I should've set the 'invalid IP's to empty strings, and validated them at parse time.