mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #554] Avoid external Google fonts #419
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#419
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bt90 on GitHub (Dec 23, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/554
Both https://docs.ntfy.sh/ and the self-hosted instances currently make use of Google Fonts.
At least for users in Germany (and probably the entire EU), this is a potential violation of the GDPR: https://thehackernews.com/2022/01/german-court-rules-websites-embedding.html
Could we bundle them as regular assets instead?
@binwiederhier commented on GitHub (Dec 23, 2022):
Yeah I agree. Good catch.
@clementduveau commented on GitHub (Jan 12, 2023):
I investigated this issue:
2743c96694seems to have deleted all references to google fonts.@binwiederhier commented on GitHub (Mar 12, 2023):
The ntfy web app + website does not include Google Fonts at all.
As you correctly identified, the docs do include Google Fonts. The linked
privacyplugin is currently only for sponsors, though it seems entirely possible to do this manually by overriding thefontsblock manually. Any volunteers?See https://github.com/squidfunk/mkdocs-material/issues/739#issuecomment-396045972
@ozskywalker commented on GitHub (Mar 12, 2023):
Have submitted PR #667
Let me know if this is acceptable
@binwiederhier commented on GitHub (Mar 13, 2023):
Done in #667 and #668, will be in next release.