mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #552] Enable HTTP/2 for ntfy.sh #420
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#420
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @otbutz on GitHub (Dec 21, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/552
Any reason that https://ntfy.sh is limited to HTTP/1.1 ?
@binwiederhier commented on GitHub (Dec 22, 2022):
Good question. No particular reason, other than I have never set that up for nginx. I could probably do it. Do you happen to have experience with that @otbutz?
Here's how it's set up: https://github.com/binwiederhier/ntfy-ansible/blob/main/roles/nginx/templates/sites-available/ntfy.j2
@binwiederhier commented on GitHub (Dec 22, 2022):
Looks like it's just adding the
http2stanza: https://ubiq.co/tech-blog/how-to-enable-http2-in-nginx/Maybe I'll yolo-deploy that tomorrow and see what happens.
@otbutz commented on GitHub (Dec 22, 2022):
I would follow Mozillas best practices and also enable TLS1.3 while you're at it:
https://ssl-config.mozilla.org/#server=nginx&version=1.17.7&config=intermediate&openssl=1.1.1k&hsts=false&ocsp=false&guideline=5.6 (You should really consider to ditch HTTP and enforce HTTPS with HSTS.)
You could also switch to caddy if you're feeling adventurous and get HTTP/3 support 😉
@binwiederhier commented on GitHub (Dec 22, 2022):
Sure why not.
Nope. That prevents the awesome
curl -d hi ntfy.sh/yousage. Don't wanna typehttps://all the time, and I am usually not fearing MITM or sharing state secrets. If people are, they can set up their own server.If it ain't broke, don't fix it. :-D
@otbutz commented on GitHub (Dec 22, 2022):
That should still work without https:// if you allow curl to follow redirects:
@binwiederhier commented on GitHub (Dec 23, 2022):
See https://github.com/binwiederhier/ntfy-ansible/pull/1
@binwiederhier commented on GitHub (Dec 23, 2022):
Sadly the Unix socket change causes a (benign) warning in the ntfy code for every single request (
r.RemoteAddrnow contains@, instead of an IP address), which means I need a small code change to handle that case. Otherwise I'd get flooded in warnings.@otbutz commented on GitHub (Dec 23, 2022):
Shouldn't the remote address not be populated from
X-Forwarded-Forheader in this case?