mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 16:35:53 +02:00
[GH-ISSUE #652] Android: Add Rate-Topics: header to UnifiedPush subscriptions #484
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#484
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @binwiederhier on GitHub (Mar 3, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/652
For UnifiedPush topic subscriptions, we need to add a header
Rate-Topics: ...to the JSON stream and WebSocket Connection, so that the server can rate limit based on the subscriber. Right now, this is done solely based on the topic nameup<12 digits>, which was meant to be temporary.@binwiederhier commented on GitHub (Mar 3, 2023):
/cc @wunter8 While you're in the Android codebase 😬
@wunter8 commented on GitHub (Mar 3, 2023):
Haha, I'll see if I can get to this over the weekend. What exactly am I doing, though?? Is there a Discord/Matrix thread I should refer to for context?
@binwiederhier commented on GitHub (Mar 3, 2023):
Basically, you're listing all UnifiedPush topics in the GET request for the subscription connection, e.g.
This will tell the ntfy server to register visitor as a rate visitor for the UP topics, but not the others. I am happy to give more details, but this is poorly documented, as it is still be ironed out.