mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #664] UnifiedPush: Respond with 404/409/... to Mastodon/etc. instead of 507 based on User-Agent #490
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#490
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @binwiederhier on GitHub (Mar 8, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/664
Similar to the Matrix Push Gateway change, we should respond to Mastodon/etc. in a way that will make them delete the push subscription.
Mastodon:
github.com/mastodon/mastodon@730bb3e211/app/workers/web/push_notification_worker.rb (L35-L46)Common-Proxies:
https://github.com/UnifiedPush/common-proxies/blob/main/gateway/matrix.go#L63
/cc FYI @karmanyaahm @p1gp1g
@p1gp1g commented on GitHub (Mar 8, 2023):
Returning 404 for all non existant UnifiedPush requests (where up=1) will follow UnifiedPush spec and Webpush spec and probably avoid many issues :)
RFC 8030 (Webpush)
UnifiedPush
@p1gp1g commented on GitHub (Mar 17, 2023):
From the discussion in chat:
Maybe returning 404 after some time (12h ?) for the same reasons we chose to do so for matrix ?
@binwiederhier commented on GitHub (May 23, 2023):
@karmanyaahm @p1gp1g I am inclined to close this, since nobody has complained. The 5xx rates are still high, but I have just learned to live with it ... Thoughts?
@karmanyaahm commented on GitHub (May 25, 2023):
If no one's having noticable problems, it ought to be fine. Still kinda weird it hasn't normalized down though :/
@Lastorder-DC commented on GitHub (Jul 7, 2023):
EDITED by @binwiederhier: Removed image containing lots of 507 errors to UP topics. The UP topics are secrets, so I removed the picture.
It keeps happening and increasing.
@binwiederhier commented on GitHub (Jul 7, 2023):
@Lastorder-DC please censor the picture. Unified Push topics are secrets.
Edit: I took the liberty of removing the image for you.
@binwiederhier commented on GitHub (Jul 7, 2023):
This is happening because your server is pushing messages to topics that do not have any subscribers. They are dead topics.
The alternative to returning 507 would be to let them through, but then you'd get rate limited and banned within a matter of minutes. So you can either live with the errors, or manually purge the topics from Mastodon.
I am also ok with pull requests to handle it specifically for Mastodon if there are suggestions.
@Lastorder-DC commented on GitHub (Jul 8, 2023):
@binwiederhier Forgot that. Sorry! (Actually I have sensored them but accidently choose non-sensored version...)
@ShadowJonathan commented on GitHub (Jul 20, 2023):
We're seeing a buildup of push messages to ntfy.sh, presumably to UP. Returning a 4XX code so that the queue is deleted would help a lot, since we're continually getting IP banned by the sheer volume of requests backed up.
Also relevant: https://github.com/mastodon/mastodon/issues/26078
@ShadowJonathan commented on GitHub (Aug 18, 2023):
I've talked with @karmanyaahm about this issue, and the consensus seems to be that, 12h after deletion, nfty should be returning 410s for a given subscription.
@ShadowJonathan commented on GitHub (Aug 18, 2023):
Actually, the
.Stale()function will give a better approximation of when to expire.