mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #794] PWA manifest 404 error #563
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#563
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hockey6611 on GitHub (Jun 29, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/794
🐞 Describe the bug
I am running ntfy selfhosted behind a proxy with valid https certificate. Was excited to play with the new PWA in 2.6.0 and then in 2.6.1. However I am receiving a 404 error on my browser for the manifest:
{"code":40401,"http":404,"error":"page not found"}💻 Components impacted
PWA on all platforms
💡 Screenshots and/or logs
Web browser console/headers:
Web browser response:
ntfy docker trace logs
🔮 Additional context
I run ntfy on docker, with http :80 running to Nginx Proxy Manager as my reverse proxy. Docker compose below. In troubleshooting course, I noted PWA manifest has to be served over https, which I am doing. Would this have anything to do with my proxy config?
@codebude commented on GitHub (Jun 29, 2023):
Same problem on my setup. I use Traefik as reverse proxy in front of Ntfy. I also get the 404 for the
/manifest.webmanifest.@nimbleghost commented on GitHub (Jun 29, 2023):
@hockey6611 @codebude Did you set up the web push config variables? The PWA is not available without them:
https://docs.ntfy.sh/config/#web-push
@Havock94 commented on GitHub (Jun 29, 2023):
Had the same problem, I missed the configuration needed to install the PWA. Can confirm the above docs solves the problem.
Just as a note, you should also set the
base-urlparam in server.yml to make it work, as I was getting the following log after just setting the parameters returned fromntfy webpush keys:@codebude commented on GitHub (Jun 29, 2023):
@nimbleghost Yes, adding the webpush config solved it!
Maybe a quick hint in the PWA section of the documentation or in the release notes had would have avoided confusion.
The only thing I wonder: If PWA doesn't work without the web push settings shouldn't then the manifest.webmanifest file be not included in the HTML code at all, instead of linking, but not serving it (which leads to an 404 error).
@nimbleghost commented on GitHub (Jun 29, 2023):
Indeed, though it's a bit tricky to do since the
index.htmlis pre-built and the config is dynamic@hockey6611 commented on GitHub (Jun 29, 2023):
@nimbleghost thank you! PWA now seems to work in my instance.
@codebude
@Havock94
I had the
base-urlset, but did not set upweb-push-email-addresson my initial attempt, and I received the same error, and ntfy did not start. So it seems all 5 must be set.Closing the issue, thank you!
@binwiederhier commented on GitHub (Jun 30, 2023):
I could have sworn I tested this. So the "Install" shows up even when the "web-push-*" stuff is not there? That's not cool..
@hockey6611 commented on GitHub (Jun 30, 2023):
No, for me the "Install" did not show up. But the manifest.webmanifest file did show up in the console albeit with the 404 error.
@codebude commented on GitHub (Jun 30, 2023):
@binwiederhier Same for me. Install button didn't show up. But from reading the release notes I thought it would show up without any further setup/config. Then I checked Chrome's developer console and saw that the manifest.webmabifest was throwing an HTTP 404 error. Thus I thought it was a bug initially.
@nimbleghost commented on GitHub (Jun 30, 2023):
yeah like they said, just the 404 in the console. would be nice to fix but will require dynamically adding it in the go server.
perhaps we should update the release notes to say config is required, plus add a note to https://docs.ntfy.sh/subscribe/pwa/ saying that the config is needed on self hosted servers