mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #831] Support icons for desktop notifications in web app #587
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#587
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Hakkin on GitHub (Aug 3, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/831
💡 Idea
Currently, the web app just sets a constant URL as the icon with no way to change it.
github.com/binwiederhier/ntfy@8ba4b72b37/web/src/app/notificationUtils.js (L50)Desktop notifications support supplying arbitrary URLs for the icon, so it makes sense to just pass along the supplied icon URL. This should work pretty much exactly like the
imagehandling code in that function block.github.com/binwiederhier/ntfy@8ba4b72b37/web/src/app/notificationUtils.js (L54)It's currently possible to display images in the notification through the
attachparameter, but this is done through theimagenotification option, which is only supported by Chrome-based browsers. Theiconoption is supported by all major browsers.💻 Target components
Web app
@Hakkin commented on GitHub (Aug 3, 2023):
Alternatively: Add a fallback for displaying image attachments using
iconfor non-Chrome browsers.