mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #928] Adding a configuration option to force sending a EVENT_MESSAGE #649
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#649
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheBlusky on GitHub (Oct 23, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/928
🤔 Problem
When pushing an event, the ntfy server got some heuristic in order to determinate whether or not sending to Firebase an
EVENT_MESSAGEor aEVENT_POLL_REQUEST. I think the reason behind it, is to prevent info leakage to Firebase.Comments says
If anonymous read for a topic is not allowed, we cannot send the message along via Firebase. Instead, we send a "poll_request" message, asking the client to poll..More than that, users might want to always, or never send information to Firebase.
💡 Idea
The idea is to add a configuration option to bypass this heuristic, either by
EVENT_MESSAGE(if the admin does not mind sending information to Firebase)EVENT_POLL(if the admin always mind sending information to Firebase)For this, a new
FIREBASE_EVENT_STRATEGYconfiguration option can be used.💻 Target components
FIREBASE_EVENT_STRATEGYsettings configuration, that might be set toAUTO/MESSAGE/POLL.ntfy/server/server_firebase.go, changing theifline 145If this feature might be accepted, I am willing to fork and write a PR with implementation.
@FamliarMan commented on GitHub (Feb 26, 2024):
is this feature supported now ?
@wunter8 commented on GitHub (Feb 26, 2024):
This has not been implemented yet