[GH-ISSUE #109] refactoring message receive handling #88

New issue

Closed

opened 2026-05-07 00:19:47 +02:00 by BreizhHardware · 2 comments

BreizhHardware commented

2026-05-07 00:19:47 +02:00

Owner

Originally created by @genofire on GitHub (Jan 19, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/109

The parsing of an message and delivery (into SMTP and so on) should be split into two functions:

github.com/binwiederhier/ntfy@c83b5c6e73/server/server.go (L411)

Otherwise a handling of multiple message (a batch of message) in one request is not possible like needed here: #104

Originally created by @genofire on GitHub (Jan 19, 2022). Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/109 The parsing of an message and delivery (into SMTP and so on) should be split into two functions: https://github.com/binwiederhier/ntfy/blob/c83b5c6e73c6b386b83a63a77704d8e40fb45df3/server/server.go#L411 Otherwise a handling of multiple message (a batch of message) in one request is not possible like needed here: #104

BreizhHardware closed this issue

2026-05-07 00:19:47 +02:00

BreizhHardware commented

2026-05-07 00:19:47 +02:00

Author

Owner

@genofire commented on GitHub (Jan 19, 2022):

This Workaround over sending an Request should also be solved with it:

github.com/binwiederhier/ntfy@c83b5c6e73/server/server.go (L1005-L1013)

@genofire commented on GitHub (Jan 19, 2022): This Workaround over sending an Request should also be solved with it: https://github.com/binwiederhier/ntfy/blob/c83b5c6e73c6b386b83a63a77704d8e40fb45df3/server/server.go#L1005-L1013

BreizhHardware commented

2026-05-07 00:19:47 +02:00

Author

Owner

@binwiederhier commented on GitHub (Feb 5, 2022):

I think I'll figure out how to structure the code when/if I do #104. Than you for your feedback though. Much appreciated, keep it coming.

@binwiederhier commented on GitHub (Feb 5, 2022): I think I'll figure out how to structure the code when/if I do #104. Than you for your feedback though. Much appreciated, keep it coming.

BreizhHardware referenced this issue

2026-05-07 01:01:03 +02:00

[PR #89] [MERGED] WIP: Listen on Unix socket #1218