mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #1253] Logic issue with NTFY_PASSWORD on pass-change? #885
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#885
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pixitha on GitHub (Jan 6, 2025).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/1253
🐞 Describe the bug
I have ntfy running in a docker container (fly.io) and was adding a 2nd user via terminal inside of the docker container. Running the change-pass function with the ntfy server client was never asking for a password. I didn't realize that I had set the ENV variable for this, to run on the initial setup, but after the initial setup it never gets used. This created a silent failure (on my part) that whenever I try to change any user password, it always uses the original ENV variable.
💻 Components impacted
ntfy server/user auth
💡 Screenshots and/or logs
This leads to a slightly confusing silent password change, it might be worth adding some output to the user.go code to reflect when its using the env variable, since it can be a bit confusing why its not prompting for the password like you would expect?
🔮 Additional context