[PR #86] [MERGED] Drop user created server's resource entry minimum limit to 0 #105

New issue

Closed

opened 2026-05-07 00:18:07 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:18:07 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/86
Author: @yesrod
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @Boy132

Base: main ← Head: x-fix-user-creatable-cpu-limit

📝 Commits (2)

1f9ce60 fix: drop user resource limit to 0
de20bf4 fix: only allow unlimited resources for servers if the user doesn't have a global limit in that resource

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 user-creatable-servers/src/Filament/Components/Actions/CreateServerAction.php (+3 -3)
📝 user-creatable-servers/src/Filament/Server/Pages/ServerResourcePage.php (+3 -3)

📄 Description

The rest of the code is already set up to treat 0 as "unlimited", as far as I can tell, but the UI elements were limiting the minimum to 1. This change allows users to specify unlimited resources for a specific server if the user is not globally limited in that resource. I've tested this on my local Pelican instance, and it works as intended.

Summary by CodeRabbit

Bug Fixes
- Updated server resource input validation: CPU, memory, and disk fields can now accept zero when a user has no corresponding resource limit, instead of enforcing a minimum of 1. Existing maximum limits, hints and validations remain unchanged.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/86 **Author:** [@yesrod](https://github.com/yesrod) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `x-fix-user-creatable-cpu-limit` --- ### 📝 Commits (2) - [`1f9ce60`](https://github.com/pelican-dev/plugins/commit/1f9ce606b19b1b9399db603f7521b68ea5b393b3) fix: drop user resource limit to 0 - [`de20bf4`](https://github.com/pelican-dev/plugins/commit/de20bf4f5a9a8e41e47961d08d7de14a965396e9) fix: only allow unlimited resources for servers if the user doesn't have a global limit in that resource ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `user-creatable-servers/src/Filament/Components/Actions/CreateServerAction.php` (+3 -3) 📝 `user-creatable-servers/src/Filament/Server/Pages/ServerResourcePage.php` (+3 -3) </details> ### 📄 Description The rest of the code is already set up to treat 0 as "unlimited", as far as I can tell, but the UI elements were limiting the minimum to 1. This change allows users to specify unlimited resources for a specific server if the user is not globally limited in that resource. I've tested this on my local Pelican instance, and it works as intended.  ## Summary by CodeRabbit * **Bug Fixes** * Updated server resource input validation: CPU, memory, and disk fields can now accept zero when a user has no corresponding resource limit, instead of enforcing a minimum of 1. Existing maximum limits, hints and validations remain unchanged. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>