starred/plugins
1
0
Fork 0
mirror of https://github.com/pelican-dev/plugins.git synced 2026-05-09 08:26:01 +02:00
Code Issues 13 Projects Packages Wiki Activity

[PR #92] [MERGED] delete subdomain on server delete #109

New issue
Closed
opened 2026-05-07 00:18:09 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-07 00:18:09 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/92
Author: @TinyMemoria
Created: 1/26/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @Boy132

Base: main ← Head: deleteserver

📝 Commits (4)

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 subdomains/src/Providers/SubdomainsPluginProvider.php (+12 -0)

📄 Description

Fixes #88

Added event listener for "deleting" event and deletes subdomain.
Not throwing exception to not interfere with server deletion.

Summary by CodeRabbit

  • Bug Fixes
    • Automatic subdomain cleanup on server deletion: when a server is removed, all associated subdomains are now deleted automatically. Individual deletion failures are caught and reported so cleanup continues, preventing orphaned subdomains and improving consistency and error visibility during server removal.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/92 **Author:** [@TinyMemoria](https://github.com/TinyMemoria) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `deleteserver` --- ### 📝 Commits (4) - [`8008d95`](https://github.com/pelican-dev/plugins/commit/8008d9551033f1587ed3b9c7c03cf13b9f544edf) delete subdomain on server delete - [`30588b1`](https://github.com/pelican-dev/plugins/commit/30588b1c1f8c81cc6e55cdc2bd2b03eedd7ad9df) log the exception - [`dd4f571`](https://github.com/pelican-dev/plugins/commit/dd4f57160323750696c927a0570eb32541c3c067) pint fixes - [`ba4455f`](https://github.com/pelican-dev/plugins/commit/ba4455f0663acdb84fdffbba973bb75aec38fa64) Apply suggestion from @Boy132 ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `subdomains/src/Providers/SubdomainsPluginProvider.php` (+12 -0) </details> ### 📄 Description Fixes #88 Added event listener for "deleting" event and deletes subdomain. Not throwing exception to not interfere with server deletion. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Automatic subdomain cleanup on server deletion: when a server is removed, all associated subdomains are now deleted automatically. Individual deletion failures are caught and reported so cleanup continues, preventing orphaned subdomains and improving consistency and error visibility during server removal. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:18:09 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
register/email-verification
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/plugins#109
No description provided.