starred/plugins
1
0
Fork 0
mirror of https://github.com/pelican-dev/plugins.git synced 2026-05-09 08:26:01 +02:00
Code Issues 13 Projects Packages Wiki Activity

[PR #97] [CLOSED] feat(loader): add support for Purpur, Folia and more #111

New issue
Closed
opened 2026-05-07 00:18:09 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-07 00:18:09 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/97
Author: @KinglyShade
Created: 2/4/2026
Status: ❌ Closed

Base: main ← Head: feat/add-extended-loaders

📝 Commits (10+)

  • 29f3783 feat(loader): add support for Purpur, Folia and more
  • 818283f fix: code style and phpstan errors
  • e10db3e Refactor MinecraftLoader enum and methods
  • 6936781 Refactor MinecraftLoader enum formatting and comments
  • b5be999 Refactor fromTags method for better readability
  • 65561c9 Refactor MinecraftLoader enum and fromTags method
  • 98a888f Refactor MinecraftLoader.php for clarity
  • 5163101 Improve PHPDoc for tags variable in fromServer method
  • fc5906a Refactor MinecraftLoader methods for clarity
  • 5a46b92 Remove space in in_array check for tags

📊 Changes

1 file changed (+32 additions, -33 deletions)

View changed files

📝 minecraft-modrinth/src/Enums/MinecraftLoader.php (+32 -33)

📄 Description

This PR expands the MinecraftLoader enum to support additional popular server forks and proxies. This allows the Minecraft Modrinth plugin to correctly identify the server type and filter compatible plugins/mods from Modrinth more accurately.
Changes

Added new loaders: Purpur, Folia, Pufferfish, Spigot, Bukkit, and Waterfall.

Refactored fromTags method: Replaced nested if statements with a more efficient match(true) structure (PHP 8.x).

Improved tag detection: Added support for common tag variations like papermc, spigotmc, and neoforged.

Summary by CodeRabbit

  • New Features

    • Expanded server loader detection to include Purpur, Folia, Pufferfish, Paper (PaperMC), Spigot (SpigotMC), Bukkit, Velocity, Waterfall, and BungeeCord.
    • Improved alias mapping for more accurate identification of a wider range of Minecraft server setups, reducing misclassification and increasing compatibility.

  • Bug Fixes / Improvements

    • Cleaner handling when no matching loader is found.
    • Improved display labels for detected loaders (consistent title-casing).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/97 **Author:** [@KinglyShade](https://github.com/KinglyShade) **Created:** 2/4/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/add-extended-loaders` --- ### 📝 Commits (10+) - [`29f3783`](https://github.com/pelican-dev/plugins/commit/29f37830ae00bbec104d49ca50992b346bfeb873) feat(loader): add support for Purpur, Folia and more - [`818283f`](https://github.com/pelican-dev/plugins/commit/818283f29ce53810e63ffa6d82d79429b85fa36f) fix: code style and phpstan errors - [`e10db3e`](https://github.com/pelican-dev/plugins/commit/e10db3e9f1dccfa92aa9cf6ab09a64c1e73782da) Refactor MinecraftLoader enum and methods - [`6936781`](https://github.com/pelican-dev/plugins/commit/6936781f1081a0e8943c68f9fcd2b500c8719322) Refactor MinecraftLoader enum formatting and comments - [`b5be999`](https://github.com/pelican-dev/plugins/commit/b5be9993fe09bae301708707b2968f601b5dc030) Refactor fromTags method for better readability - [`65561c9`](https://github.com/pelican-dev/plugins/commit/65561c92d3f3b449a8294a9fd6a0e03a7699ccf3) Refactor MinecraftLoader enum and fromTags method - [`98a888f`](https://github.com/pelican-dev/plugins/commit/98a888f7e5a3cca14c825018add689e76908d202) Refactor MinecraftLoader.php for clarity - [`5163101`](https://github.com/pelican-dev/plugins/commit/51631018bfa11802428831c3ddebc9dc2cee1164) Improve PHPDoc for tags variable in fromServer method - [`fc5906a`](https://github.com/pelican-dev/plugins/commit/fc5906a754b4df92870a04282e8329e6f60ac7a2) Refactor MinecraftLoader methods for clarity - [`5a46b92`](https://github.com/pelican-dev/plugins/commit/5a46b921463cf142fd0425ff9848b09996ea2333) Remove space in in_array check for tags ### 📊 Changes **1 file changed** (+32 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `minecraft-modrinth/src/Enums/MinecraftLoader.php` (+32 -33) </details> ### 📄 Description This PR expands the MinecraftLoader enum to support additional popular server forks and proxies. This allows the Minecraft Modrinth plugin to correctly identify the server type and filter compatible plugins/mods from Modrinth more accurately. Changes Added new loaders: Purpur, Folia, Pufferfish, Spigot, Bukkit, and Waterfall. Refactored fromTags method: Replaced nested if statements with a more efficient match(true) structure (PHP 8.x). Improved tag detection: Added support for common tag variations like papermc, spigotmc, and neoforged. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Expanded server loader detection to include Purpur, Folia, Pufferfish, Paper (PaperMC), Spigot (SpigotMC), Bukkit, Velocity, Waterfall, and BungeeCord. * Improved alias mapping for more accurate identification of a wider range of Minecraft server setups, reducing misclassification and increasing compatibility. * **Bug Fixes / Improvements** * Cleaner handling when no matching loader is found. * Improved display labels for detected loaders (consistent title-casing). <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:18:09 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
register/email-verification
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/plugins#111
No description provided.