starred/plugins
1
0
Fork 0
mirror of https://github.com/pelican-dev/plugins.git synced 2026-05-09 08:26:01 +02:00
Code Issues 13 Projects Packages Wiki Activity

[PR #115] [CLOSED] Player Counter: Add Arma 3 and Arma Reforger support and improve Source query #118

New issue
Closed
opened 2026-05-07 00:18:13 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-07 00:18:13 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/115
Author: @szpolny
Created: 2/27/2026
Status: ❌ Closed

Base: main ← Head: player-counter/arma

📝 Commits (3)

  • 5089b94 feat(player-counter): add support for Arma 3 and Arma Reforger
  • d749ee4 fix(player-counter): make Source query more robust to avoid crashes
  • 43f16be fix(player-counter): satisfy PHPStan comparison check in Source query

📊 Changes

5 files changed (+51 additions, -7 deletions)

View changed files

📝 player-counter/plugin.json (+1 -1)
➕ player-counter/src/Extensions/Query/Schemas/Arma3QueryTypeSchema.php (+16 -0)
➕ player-counter/src/Extensions/Query/Schemas/ArmaReforgerQueryTypeSchema.php (+16 -0)
📝 player-counter/src/Extensions/Query/Schemas/SourceQueryTypeSchema.php (+14 -6)
📝 player-counter/src/Providers/PlayerCounterPluginProvider.php (+4 -0)

📄 Description

This pull request introduces support for Arma 3 and Arma Reforger server types to the Player Counter plugin, along with improvements for more robust server information querying and error handling.

New server type support

  • Added Arma3QueryTypeSchema and ArmaReforgerQueryTypeSchema classes to support querying Arma 3 and Arma Reforger servers. [1] [2]
  • Registered the new schemas in the PlayerCounterPluginProvider so they are available for use. [1] [2]

Plugin metadata

  • Updated the plugin version in plugin.json to 1.1.0 to reflect the new features.

Summary by CodeRabbit

  • New Features

    • Added support for querying Arma 3 servers
    • Added support for querying Arma Reforger servers

  • Bug Fixes

    • Improved null safety and error handling in server query operations

  • Chores

    • Plugin metadata updated to version 1.1.0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/115 **Author:** [@szpolny](https://github.com/szpolny) **Created:** 2/27/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `player-counter/arma` --- ### 📝 Commits (3) - [`5089b94`](https://github.com/pelican-dev/plugins/commit/5089b9495b04d035020edb929a3fa85092c8995e) feat(player-counter): add support for Arma 3 and Arma Reforger - [`d749ee4`](https://github.com/pelican-dev/plugins/commit/d749ee4625f598e4faafa3e7a1df9e917fb68f7a) fix(player-counter): make Source query more robust to avoid crashes - [`43f16be`](https://github.com/pelican-dev/plugins/commit/43f16be2d09c9e0bbecbf818382b87805be3d5db) fix(player-counter): satisfy PHPStan comparison check in Source query ### 📊 Changes **5 files changed** (+51 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `player-counter/plugin.json` (+1 -1) ➕ `player-counter/src/Extensions/Query/Schemas/Arma3QueryTypeSchema.php` (+16 -0) ➕ `player-counter/src/Extensions/Query/Schemas/ArmaReforgerQueryTypeSchema.php` (+16 -0) 📝 `player-counter/src/Extensions/Query/Schemas/SourceQueryTypeSchema.php` (+14 -6) 📝 `player-counter/src/Providers/PlayerCounterPluginProvider.php` (+4 -0) </details> ### 📄 Description This pull request introduces support for Arma 3 and Arma Reforger server types to the Player Counter plugin, along with improvements for more robust server information querying and error handling. ### New server type support * Added `Arma3QueryTypeSchema` and `ArmaReforgerQueryTypeSchema` classes to support querying Arma 3 and Arma Reforger servers. [[1]](diffhunk://#diff-50e96aa1d0ec997d7443513209b330ae9a5a2035ec6a6e91fd52574abbb0aa9cR1-R16) [[2]](diffhunk://#diff-b34c8dfcad3473a30291f4de3cdb39fb2d85ad026e449fedebb76e7328a64135R1-R16) * Registered the new schemas in the `PlayerCounterPluginProvider` so they are available for use. [[1]](diffhunk://#diff-2d2b9116427b53d9c2a217e28f392f720fed3ee8573670c63af45c19582380a0R10-R11) [[2]](diffhunk://#diff-2d2b9116427b53d9c2a217e28f392f720fed3ee8573670c63af45c19582380a0R40-R41) ### Plugin metadata * Updated the plugin version in `plugin.json` to `1.1.0` to reflect the new features. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for querying Arma 3 servers * Added support for querying Arma Reforger servers * **Bug Fixes** * Improved null safety and error handling in server query operations * **Chores** * Plugin metadata updated to version 1.1.0 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:18:13 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
register/email-verification
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/plugins#118
No description provided.