[PR #119] [CLOSED] Player Counter Queries #122

Closed
opened 2026-05-07 00:18:14 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/119
Author: @AdmiralScoob
Created: 4/5/2026
Status: Closed

Base: mainHead: patch-1


📝 Commits (2)

  • eebd989 Update GameQuery.php
  • 29cbb83 Fix IP alias resolution in GameQuery

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 player-counter/src/Models/GameQuery.php (+2 -2)

📄 Description

Modified "runQuery" and "canRunQuery" to use gethostbyname with the allocation alias to fix issues with non-IP container aliases.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced hostname alias resolution for server queries. When alias configuration is enabled, the system now properly resolves hostnames to their corresponding IP addresses, improving query reliability.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/119 **Author:** [@AdmiralScoob](https://github.com/AdmiralScoob) **Created:** 4/5/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`eebd989`](https://github.com/pelican-dev/plugins/commit/eebd9893416d944f632d68d14b4fe4a8fd742f3b) Update GameQuery.php - [`29cbb83`](https://github.com/pelican-dev/plugins/commit/29cbb83244cb782eec181eb73538bcf0034ebc46) Fix IP alias resolution in GameQuery ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `player-counter/src/Models/GameQuery.php` (+2 -2) </details> ### 📄 Description Modified "runQuery" and "canRunQuery" to use gethostbyname with the allocation alias to fix issues with non-IP container aliases. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced hostname alias resolution for server queries. When alias configuration is enabled, the system now properly resolves hostnames to their corresponding IP addresses, improving query reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:18:14 +02:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/plugins#122
No description provided.