[GH-ISSUE #24] [Minecraft-Modrinth]Issue with Fixes #23

Closed
opened 2026-05-07 00:17:08 +02:00 by BreizhHardware · 2 comments

Originally created by @ConsoleGods on GitHub (Dec 20, 2025).
Original GitHub issue: https://github.com/pelican-dev/plugins/issues/24

Search feature not working correctly

Image

FIx

From:
public function getModrinthProjects(Server $server, int $page = 1, ?string $ = null): array

To:
public function getModrinthProjects(Server $server, int $page = 1, ?string $search = null): array

From:
return cache()->remember("modrinth_projects:{$projectType->value}:$minecraftVersion:$minecraftLoader:$page", now()->addMinutes(30), function () use ($data) {

To:
return cache()->remember("modrinth_projects:{$projectType->value}:$minecraftVersion:$minecraftLoader:$page:" . ($search ?? 'all'), now()->addMinutes(30), function () use ($data) {

Originally created by @ConsoleGods on GitHub (Dec 20, 2025). Original GitHub issue: https://github.com/pelican-dev/plugins/issues/24 Search feature not working correctly <img width="891" height="567" alt="Image" src="https://github.com/user-attachments/assets/17f4de51-2030-498d-baf4-6b6464e1df6d" /> FIx From: `public function getModrinthProjects(Server $server, int $page = 1, ?string $ = null): array` To: `public function getModrinthProjects(Server $server, int $page = 1, ?string $search = null): array` From: `return cache()->remember("modrinth_projects:{$projectType->value}:$minecraftVersion:$minecraftLoader:$page", now()->addMinutes(30), function () use ($data) {` To: `return cache()->remember("modrinth_projects:{$projectType->value}:$minecraftVersion:$minecraftLoader:$page:" . ($search ?? 'all'), now()->addMinutes(30), function () use ($data) {`
Author
Owner

@coderabbitai[bot] commented on GitHub (Dec 20, 2025):

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

  • Create Plan
Examples

🔗 Similar Issues

Possible Duplicates

👤 Suggested Assignees

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

<!-- gh-comment-id:3678027012 --> @coderabbitai[bot] commented on GitHub (Dec 20, 2025): <!-- This is an auto-generated issue plan by CodeRabbit --> ### 📝 CodeRabbit Plan Mode Generate an implementation plan and prompts that you can use with your favorite coding agent. - [ ] <!-- {"checkboxId": "8d4f2b9c-3e1a-4f7c-a9b2-d5e8f1c4a7b9"} --> Create Plan <details> <summary>Examples</summary> - [Example 1](https://github.com/coderabbitai/git-worktree-runner/issues/29#issuecomment-3589134556) - [Example 2](https://github.com/coderabbitai/git-worktree-runner/issues/12#issuecomment-3606665167) </details> --- <details> <summary><b>🔗 Similar Issues</b></summary> **Possible Duplicates** - https://github.com/pelican-dev/plugins/issues/14 </details> <details> <summary><b>👤 Suggested Assignees</b></summary> - [Ametic](https://github.com/Ametic) </details> --- <details> <summary> 🧪 Issue enrichment is currently in open beta.</summary> You can configure auto-planning by selecting labels in the issue_enrichment configuration. To disable automatic issue enrichment, add the following to your `.coderabbit.yaml`: ```yaml issue_enrichment: auto_enrich: enabled: false ``` </details> 💬 Have feedback or questions? Drop into our [discord](https://discord.gg/coderabbit) or [schedule a call](https://calendly.com/parth-coderabbit/issues-feedback)!
Author
Owner

@Boy132 commented on GitHub (Dec 20, 2025):

Update your plugin, this has already been fixed.

<!-- gh-comment-id:3678079619 --> @Boy132 commented on GitHub (Dec 20, 2025): Update your plugin, this has already been fixed.
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/plugins#23
No description provided.