[PR #32] [CLOSED] fix: mclogs visibility #74

New issue

Closed

opened 2026-05-07 00:17:55 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:17:55 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/32
Author: @SilberGecko6917
Created: 12/20/2025
Status: ❌ Closed

Base: main ← Head: fix/mclogs-visibility

📝 Commits (2)

4c5488d improve visibility logic for upload logs action
01a5eaf add note for enabling mclogs upload button

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 README.md (+3 -0)
📝 mclogs-uploader/src/Filament/Components/Actions/UploadLogsAction.php (+12 -1)

📄 Description

#31
This PR updates the mclogs uploader feature to ensure the "Upload Logs" button is only shown the egg includes the mclogs feature. It also updates the documentation to inform users about this requirement.

Summary by CodeRabbit

Documentation
- Added clarification that the mclogs feature must be configured and enabled on the server to use the upload logs button.
Bug Fixes
- The upload logs button now correctly hides when the server's egg configuration does not include the mclogs feature.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/32 **Author:** [@SilberGecko6917](https://github.com/SilberGecko6917) **Created:** 12/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/mclogs-visibility` --- ### 📝 Commits (2) - [`4c5488d`](https://github.com/pelican-dev/plugins/commit/4c5488da78798f384f04a33f0a2e37fbf22cf235) improve visibility logic for upload logs action - [`01a5eaf`](https://github.com/pelican-dev/plugins/commit/01a5eaf21e397997a98ce34f5aa466975ebc8540) add note for enabling mclogs upload button ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -0) 📝 `mclogs-uploader/src/Filament/Components/Actions/UploadLogsAction.php` (+12 -1) </details> ### 📄 Description #31 This PR updates the mclogs uploader feature to ensure the "Upload Logs" button is only shown the egg includes the `mclogs` feature. It also updates the documentation to inform users about this requirement.  ## Summary by CodeRabbit * **Documentation** * Added clarification that the mclogs feature must be configured and enabled on the server to use the upload logs button. * **Bug Fixes** * The upload logs button now correctly hides when the server's egg configuration does not include the mclogs feature. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>