[GH-ISSUE #181] hardcoded refinement_prompt_attr issue - fails when not using AWS and using AI. #107

Closed
opened 2026-05-06 12:37:32 +02:00 by BreizhHardware · 3 comments

Originally created by @s7oneyuk on GitHub (Mar 30, 2026).
Original GitHub issue: https://github.com/patrickchugh/terravision/issues/181

Issue in LLM.py....

refinement_prompt_attr = f"{provider.upper()}_REFINEMENT_PROMPT"
refinement_prompt = getattr(
config, refinement_prompt_attr, config.AWS_REFINEMENT_PROMPT
)

means you hardcoded the refinement prompt to AWS. This should be based on the provider detected instead.

Originally created by @s7oneyuk on GitHub (Mar 30, 2026). Original GitHub issue: https://github.com/patrickchugh/terravision/issues/181 Issue in LLM.py.... refinement_prompt_attr = f"{provider.upper()}_REFINEMENT_PROMPT" refinement_prompt = getattr( config, refinement_prompt_attr, config.AWS_REFINEMENT_PROMPT ) means you hardcoded the refinement prompt to AWS. This should be based on the provider detected instead.
Author
Owner

@patrickchugh commented on GitHub (Apr 3, 2026):

Thanks for reporting this. The AI feature is still experimental and is due for a major revamp in the next release. Please keep an eye out for future releases.

<!-- gh-comment-id:4183216139 --> @patrickchugh commented on GitHub (Apr 3, 2026): Thanks for reporting this. The AI feature is still experimental and is due for a major revamp in the next release. Please keep an eye out for future releases.
Author
Owner

@patrickchugh commented on GitHub (Apr 14, 2026):

@s7oneyuk Please try with the latest release and let me know how it goes

<!-- gh-comment-id:4245257204 --> @patrickchugh commented on GitHub (Apr 14, 2026): @s7oneyuk Please try with the latest release and let me know how it goes
Author
Owner

@patrickchugh commented on GitHub (Apr 27, 2026):

Closing due to to change of approach

<!-- gh-comment-id:4325139589 --> @patrickchugh commented on GitHub (Apr 27, 2026): Closing due to to change of approach
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/terravision#107
No description provided.