[PR #34] [MERGED] Fix windows file folder compatibility #134

New issue

Closed

opened 2026-05-06 12:37:47 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:37:47 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/patrickchugh/terravision/pull/34
Author: @Lauro235
Created: 5/29/2023
Status: ✅ Merged
Merged: 6/11/2023
Merged by: @patrickchugh

Base: main ← Head: fix_windows_file_folder_compatibility

📝 Commits (2)

d42b93f fix windows os file and folder compatibility, converted python3 to python
2031c85 removed inner repo

📊 Changes

6 files changed (+11 additions, -1 deletions)

View changed files

➕ C_/Users/Lozzy/.terravision/module_cache/https_/github.com/futurice/terraform-examples.git/aws/wordpress_fargate (+1 -0)
➕ C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/acm/aws (+1 -0)
➕ C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/alb/aws (+1 -0)
➕ C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/vpc/aws (+1 -0)
📝 modules/gitlibs.py (+6 -0)
📝 terravision (+1 -1)

📄 Description

YOUR PR TITLE

The windows os handles folder and file naming differently to unix systems. This change helps make the current code Windows OS compatible. Note the other change is in the terravision file from 'python3' to 'python'

Type of Change

Bug Fix
New Feature
Refactor
Documentation

Checklist

All Submissions:

Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you written Documentation/Tests?
Have you read done your own code-review?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
[] Have you written new tests for your core changes, as applicable?
[] Have you successfully run tests with your changes locally?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/patrickchugh/terravision/pull/34 **Author:** [@Lauro235](https://github.com/Lauro235) **Created:** 5/29/2023 **Status:** ✅ Merged **Merged:** 6/11/2023 **Merged by:** [@patrickchugh](https://github.com/patrickchugh) **Base:** `main` ← **Head:** `fix_windows_file_folder_compatibility` --- ### 📝 Commits (2) - [`d42b93f`](https://github.com/patrickchugh/terravision/commit/d42b93f0ee3b959477dfbfd5a90dae4de8e9c7ca) fix windows os file and folder compatibility, converted python3 to python - [`2031c85`](https://github.com/patrickchugh/terravision/commit/2031c85fcca75c41530fb31cbad14242ed161c5d) removed inner repo ### 📊 Changes **6 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `C_/Users/Lozzy/.terravision/module_cache/https_/github.com/futurice/terraform-examples.git/aws/wordpress_fargate` (+1 -0) ➕ `C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/acm/aws` (+1 -0) ➕ `C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/alb/aws` (+1 -0) ➕ `C_/Users/Lozzy/.terravision/module_cache/terraform-aws-modules/vpc/aws` (+1 -0) 📝 `modules/gitlibs.py` (+6 -0) 📝 `terravision` (+1 -1) </details> ### 📄 Description # YOUR PR TITLE The windows os handles folder and file naming differently to unix systems. This change helps make the current code Windows OS compatible. Note the other change is in the terravision file from 'python3' to 'python' ## Type of Change * [x] Bug Fix * [ ] New Feature * [ ] Refactor * [ ] Documentation ## Checklist All Submissions: * [x] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? * [x] Have you written Documentation/Tests? * [x] Have you read done your own code-review? ### Changes to Core Features: * [x] Have you added an explanation of what your changes do and why you'd like us to include them? * [] Have you written new tests for your core changes, as applicable? * [] Have you successfully run tests with your changes locally? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>