## 📋 Pull Request Information **Original PR:** https://github.com/patrickchugh/terravision/pull/154 **Author:** [@patrickchugh](https://github.com/patrickchugh) **Created:** 12/21/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@patrickchugh](https://github.com/patrickchugh) **Base:** `main` ← **Head:** `ecs-fixes` --- ### 📝 Commits (6) - [`80871df`](https://github.com/patrickchugh/terravision/commit/80871dfe0879f021235fc2cca1de10d61dce5d5d) Implement proper ECS handler to link services with autoscaling targets - [`a2aa8bc`](https://github.com/patrickchugh/terravision/commit/a2aa8bca0fa35d18e7dbe119905199fbfb4cd037) Update ECS handler to only process EC2-based ECS, skip Fargate - [`5abf036`](https://github.com/patrickchugh/terravision/commit/5abf0366a32a52d7801b0e20024020ca0275035b) Fix ECS handler to link to autoscaling groups instead of appautoscaling targets - [`6907cba`](https://github.com/patrickchugh/terravision/commit/6907cba1e4f918eb749bbe40cb035a4f74c10a1d) Add autoscaling group and launch template expansion to numbered instances - [`ffd5742`](https://github.com/patrickchugh/terravision/commit/ffd5742b9bd15ef9948d196c8fecdb812b9aaad2) ecs ec2 fixes - [`ae7e28f`](https://github.com/patrickchugh/terravision/commit/ae7e28f885364bf1df95fc397ae2094a1826a581) Merge branch 'main' of https://github.com/patrickchugh/terravision into ecs-fixes ### 📊 Changes **11 files changed** (+973 additions, -278 deletions) <details> <summary>View changed files</summary> 📝 `docs/aws_resource_handlers/container-orchestration.md` (+395 -6) 📝 `modules/config/cloud_config_aws.py` (+8 -1) 📝 `modules/resource_handlers_aws.py` (+100 -10) 📝 `resource_classes/aws/compute.py` (+2 -0) 📝 `resource_classes/aws/groups.py` (+1 -0) 📝 `resource_classes/aws/management.py` (+1 -6) ➕ `tests/fixtures/aws_terraform/ecs-ec2/main.tf` (+124 -0) ➕ `tests/fixtures/aws_terraform/ecs-ec2/outputs.tf` (+7 -0) ➕ `tests/fixtures/aws_terraform/ecs-ec2/test.json` (+50 -0) ➕ `tests/fixtures/aws_terraform/ecs-ec2/variables.tf` (+31 -0) 📝 `tests/json/expected-wordpress.json` (+254 -255) </details> ### 📄 Description # YOUR PR TITLE ## Type of Change * [ ] Bug Fix * [ ] New Feature * [ ] Refactor * [ ] Documentation ## Checklist All Submissions: * [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? * [ ] Have you written Documentation/Tests? * [ ] Have you done your own code-review? * [ ] Have you disclosed any use of AI tools and models with their version ## AI Assistance - Tools used: [e.g., Claude Code, GitHub Copilot] - Model: [e.g., Claude Sonnet 4.5, GPT-4] - Scope: [e.g., "Generated test cases", "Refactored function X"] ### Checklist for Changes to Core Features: * [ ] Have you discussed any major revamp with a reviwer/maintainer first? * [ ] Have you added an explanation of what your changes do and why you'd like us to include them? * [ ] Have you written new tests for your core changes, as applicable and made sure they and PASS? * [ ] Have you successfully run all previous system wide tests with your changes locally? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware commented

2026-05-06 12:38:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/patrickchugh/terravision/pull/154
Author: @patrickchugh
Created: 12/21/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @patrickchugh

Base: main ← Head: ecs-fixes

📝 Commits (6)

80871df Implement proper ECS handler to link services with autoscaling targets
a2aa8bc Update ECS handler to only process EC2-based ECS, skip Fargate
5abf036 Fix ECS handler to link to autoscaling groups instead of appautoscaling targets
6907cba Add autoscaling group and launch template expansion to numbered instances
ffd5742 ecs ec2 fixes
ae7e28f Merge branch 'main' of https://github.com/patrickchugh/terravision into ecs-fixes

📊 Changes

11 files changed (+973 additions, -278 deletions)

View changed files

📝 docs/aws_resource_handlers/container-orchestration.md (+395 -6)
📝 modules/config/cloud_config_aws.py (+8 -1)
📝 modules/resource_handlers_aws.py (+100 -10)
📝 resource_classes/aws/compute.py (+2 -0)
📝 resource_classes/aws/groups.py (+1 -0)
📝 resource_classes/aws/management.py (+1 -6)
➕ tests/fixtures/aws_terraform/ecs-ec2/main.tf (+124 -0)
➕ tests/fixtures/aws_terraform/ecs-ec2/outputs.tf (+7 -0)
➕ tests/fixtures/aws_terraform/ecs-ec2/test.json (+50 -0)
➕ tests/fixtures/aws_terraform/ecs-ec2/variables.tf (+31 -0)
📝 tests/json/expected-wordpress.json (+254 -255)

📄 Description

YOUR PR TITLE

Type of Change

Bug Fix
New Feature
Refactor
Documentation

Checklist

All Submissions:

Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you written Documentation/Tests?
Have you done your own code-review?
Have you disclosed any use of AI tools and models with their version

AI Assistance

Tools used: [e.g., Claude Code, GitHub Copilot]
Model: [e.g., Claude Sonnet 4.5, GPT-4]
Scope: [e.g., "Generated test cases", "Refactored function X"]

Checklist for Changes to Core Features:

Have you discussed any major revamp with a reviwer/maintainer first?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable and made sure they and PASS?
Have you successfully run all previous system wide tests with your changes locally?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #154] [MERGED] Ecs fixes #182