[PR #156] [MERGED] Refactor graphmaker #184

Closed
opened 2026-05-06 12:38:04 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/patrickchugh/terravision/pull/156
Author: @patrickchugh
Created: 12/25/2025
Status: Merged
Merged: 12/25/2025
Merged by: @patrickchugh

Base: mainHead: refactor-graphmaker


📝 Commits (9)

  • 55163c4 adding module cross reference check
  • afae8d9 refactor check_relationship
  • c6257e1 added cross module reference check
  • 52acb2e refactored add_relations()
  • 4f123fa GVPR title fix
  • d8dde40 added new static website test for cross-module references
  • 77b524e actions
  • c88250a black
  • 96f2e5d Merge branch 'main' into refactor-graphmaker

📊 Changes

10 files changed (+8983 additions, -158 deletions)

View changed files

architecture.json (+10 -0)
📝 modules/config/cloud_config_aws.py (+6 -0)
📝 modules/graphmaker.py (+423 -157)
📝 shiftLabel.gvpr (+14 -1)
tests/fixtures/aws_terraform/static-website/main.tf (+72 -0)
tests/fixtures/aws_terraform/static-website/outputs.tf (+14 -0)
tests/fixtures/aws_terraform/static-website/variables.tf (+11 -0)
📝 tests/integration_test.py (+1 -0)
tests/json/expected-static-website.json (+13 -0)
tests/json/static-website-tfdata.json (+8419 -0)

📄 Description

YOUR PR TITLE

Type of Change

  • Bug Fix
  • New Feature
  • Refactor
  • Documentation

Checklist

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written Documentation/Tests?
  • Have you done your own code-review?
  • Have you disclosed any use of AI tools and models with their version?

AI Assistance Declaration

  • Tools used: [e.g., Claude Code, GitHub Copilot]
  • Model: [e.g., Claude Sonnet 4.5, GPT-4]
  • Scope: [e.g., "Generated test cases", "Refactored function X"]

Checklist for Changes to Core Features:

  • Have you discussed any major revamp with a reviewer/maintainer first? (It's okay to just raise a PR directly for minor bugfixes)
  • Have you ensured your PR is focused on one major improvement and is not trying to do too many changes at once? For example:
    Bad : Adding support for GCP and Azure system wide
    Good: Just adding Azure resource handler for VNets
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable, and made sure the new tests PASS?
  • Have you successfully run all previous system wide tests with your changes locally?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/patrickchugh/terravision/pull/156 **Author:** [@patrickchugh](https://github.com/patrickchugh) **Created:** 12/25/2025 **Status:** ✅ Merged **Merged:** 12/25/2025 **Merged by:** [@patrickchugh](https://github.com/patrickchugh) **Base:** `main` ← **Head:** `refactor-graphmaker` --- ### 📝 Commits (9) - [`55163c4`](https://github.com/patrickchugh/terravision/commit/55163c4cce7a4320cdbe826ba6e39f421ad60a8f) adding module cross reference check - [`afae8d9`](https://github.com/patrickchugh/terravision/commit/afae8d9e661476e70767db63a1352eb28ca98078) refactor check_relationship - [`c6257e1`](https://github.com/patrickchugh/terravision/commit/c6257e1cd0dc15daa0a442a7161612f0cd17bafc) added cross module reference check - [`52acb2e`](https://github.com/patrickchugh/terravision/commit/52acb2e98f4ae8c4139e9314be5a94669c7ef9ce) refactored add_relations() - [`4f123fa`](https://github.com/patrickchugh/terravision/commit/4f123fa69b6f6157eb313011c3bd429114b5963e) GVPR title fix - [`d8dde40`](https://github.com/patrickchugh/terravision/commit/d8dde40d6f11f26ec602f3fead26ca90ed6222c7) added new static website test for cross-module references - [`77b524e`](https://github.com/patrickchugh/terravision/commit/77b524ea629e9de78dc26924ea31f120276e5e76) actions - [`c88250a`](https://github.com/patrickchugh/terravision/commit/c88250a63291b7bca390a5c9eaa808d96ea36a41) black - [`96f2e5d`](https://github.com/patrickchugh/terravision/commit/96f2e5d6ce1f1b4c6715a204b71048d43ced7bb8) Merge branch 'main' into refactor-graphmaker ### 📊 Changes **10 files changed** (+8983 additions, -158 deletions) <details> <summary>View changed files</summary> ➕ `architecture.json` (+10 -0) 📝 `modules/config/cloud_config_aws.py` (+6 -0) 📝 `modules/graphmaker.py` (+423 -157) 📝 `shiftLabel.gvpr` (+14 -1) ➕ `tests/fixtures/aws_terraform/static-website/main.tf` (+72 -0) ➕ `tests/fixtures/aws_terraform/static-website/outputs.tf` (+14 -0) ➕ `tests/fixtures/aws_terraform/static-website/variables.tf` (+11 -0) 📝 `tests/integration_test.py` (+1 -0) ➕ `tests/json/expected-static-website.json` (+13 -0) ➕ `tests/json/static-website-tfdata.json` (+8419 -0) </details> ### 📄 Description # YOUR PR TITLE ## Type of Change * [ ] Bug Fix * [ ] New Feature * [ ] Refactor * [ ] Documentation ## Checklist All Submissions: * [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? * [ ] Have you written Documentation/Tests? * [ ] Have you done your own code-review? * [ ] Have you disclosed any use of AI tools and models with their version? ## AI Assistance Declaration - Tools used: [e.g., Claude Code, GitHub Copilot] - Model: [e.g., Claude Sonnet 4.5, GPT-4] - Scope: [e.g., "Generated test cases", "Refactored function X"] ### Checklist for Changes to Core Features: * [ ] Have you discussed any major revamp with a reviewer/maintainer first? (It's okay to just raise a PR directly for minor bugfixes) * [ ] Have you ensured your PR is focused on one major improvement and is not trying to do too many changes at once? For example: Bad : Adding support for GCP and Azure system wide Good: Just adding Azure resource handler for VNets * [ ] Have you added an explanation of what your changes do and why you'd like us to include them? * [ ] Have you written new tests for your core changes, as applicable, and made sure the new tests PASS? * [ ] Have you successfully run all previous system wide tests with your changes locally? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:38:04 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/terravision#184
No description provided.