starred/terravision

Fork 0

mirror of https://github.com/patrickchugh/terravision.git synced 2026-05-09 08:25:25 +02:00

[GH-ISSUE #51] Unable to clone versioned modules #23

New issue

Closed

opened 2026-05-06 12:36:17 +02:00 by BreizhHardware · 11 comments

BreizhHardware commented

2026-05-06 12:36:17 +02:00

Owner

Originally created by @bengels00 on GitHub (Aug 23, 2023).
Original GitHub issue: https://github.com/patrickchugh/terravision/issues/51

When trying to clone https://module?ref=foo, terravision errors while cloning without appending ?ref=foo to the URL works.
Example:

Loading Sources..
  Downloading External Module: git::https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0
    Cloning from Terraform registry source: https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0
0it [00:00, ?it/s]
ERROR: Unable to call Git to clone repository! Check git and SSH fingerprints and keys are correct and ensure the URL https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0 is reachable via CLI.

Originally created by @bengels00 on GitHub (Aug 23, 2023). Original GitHub issue: https://github.com/patrickchugh/terravision/issues/51 When trying to clone https://module?ref=foo, terravision errors while cloning without appending _?ref=foo_ to the URL works. Example: ``` Loading Sources.. Downloading External Module: git::https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0 Cloning from Terraform registry source: https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0 0it [00:00, ?it/s] ERROR: Unable to call Git to clone repository! Check git and SSH fingerprints and keys are correct and ensure the URL https://git-codecommit.eu-central-1.amazonaws.com/v1/repos/terraform-module-cloudwatch-sharing?ref=1.0 is reachable via CLI. ```

BreizhHardware closed this issue

2026-05-06 12:36:18 +02:00

BreizhHardware commented

2026-05-06 12:36:18 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 23, 2023):

Thanks this will be fixed soon

@patrickchugh commented on GitHub (Aug 23, 2023): Thanks this will be fixed soon

BreizhHardware commented

2026-05-06 12:36:18 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 26, 2023):

@bengels00 Can you git pull the latest code and try again with my latest fix?

@patrickchugh commented on GitHub (Aug 26, 2023): @bengels00 Can you git pull the latest code and try again with my latest fix?

BreizhHardware commented

2026-05-06 12:36:19 +02:00

Author

Owner

@bengels00 commented on GitHub (Aug 26, 2023):

@patrickchugh Getting our modules with ?ref=xyz suffix works now, nice! But now I'm stumbling over the following issue:

[...]
Loading Sources..
  Downloading External Module: github.com/terraform-aws-modules/terraform-aws-vpc?ref=v3.2.0
    Assuming Terraform Enterprise API Server URL: https://github.com/api/registry/v1/modules/

ERROR: No TFE_TOKEN environment variable set. Unable to authorise with Terraform Enterprise Server

(We don't use terraform enterprise at all.)

@bengels00 commented on GitHub (Aug 26, 2023): @patrickchugh Getting our modules with ?ref=xyz suffix works now, nice! But now I'm stumbling over the following issue: ``` [...] Loading Sources.. Downloading External Module: github.com/terraform-aws-modules/terraform-aws-vpc?ref=v3.2.0 Assuming Terraform Enterprise API Server URL: https://github.com/api/registry/v1/modules/ ERROR: No TFE_TOKEN environment variable set. Unable to authorise with Terraform Enterprise Server ``` (We don't use terraform enterprise at all.)

BreizhHardware commented

2026-05-06 12:36:19 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 26, 2023):

Updated the code, can you try again?

@patrickchugh commented on GitHub (Aug 26, 2023): Updated the code, can you try again?

BreizhHardware commented

2026-05-06 12:36:19 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 26, 2023):

@bengels00 The issue was the missing "http" prefix

@patrickchugh commented on GitHub (Aug 26, 2023): @bengels00 The issue was the missing "http" prefix

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@bengels00 commented on GitHub (Aug 26, 2023):

@patrickchugh well, module downloading went like a charm, now.
Unfortunately the python process is taking ~100% CPU since more than 20 minutes and has not come to some result

   PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND                                                                                                                                                                                                                  
  56324 bj        20   0  500240  54488  14848 R  99.7   0.3  22:44.57 python

@bengels00 commented on GitHub (Aug 26, 2023): @patrickchugh well, module downloading went like a charm, now. Unfortunately the python process is taking ~100% CPU since more than 20 minutes and has not come to some result ``` PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 56324 bj 20 0 500240 54488 14848 R 99.7 0.3 22:44.57 python ```

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@bengels00 commented on GitHub (Aug 26, 2023):

Module downloading is fixed.

@bengels00 commented on GitHub (Aug 26, 2023): Module downloading is fixed.

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 26, 2023):

It's probably an infinite loop and the logic interpreter has hung. If you can share the Terraform files you are using I can try to fix it ?

@patrickchugh commented on GitHub (Aug 26, 2023): It's probably an infinite loop and the logic interpreter has hung. If you can share the Terraform files you are using I can try to fix it ?

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 26, 2023):

@bengels00 you can remove any sensitive data if needed or just share the source for the last module it hung on

@patrickchugh commented on GitHub (Aug 26, 2023): @bengels00 you can remove any sensitive data if needed or just share the source for the last module it hung on

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@bengels00 commented on GitHub (Aug 26, 2023):

@patrickchugh I'd love helping to dig deeper into this, but the tf code is ~6k lines, ~250 resources, multiple times calling sub-modules, with resource names and filenames pointing to the name of our customer, the software they're using etc.
I can't even exactly identify in which module it's hanging. terravision is processing aws_ecs_service._ but that's a resource being created in 6 different module invocations and I don't see which invocation is the affected one. If I'd knew which one it is, I'd clean up the relevant terraform parts from customer references/sensitive data and supply them.

@bengels00 commented on GitHub (Aug 26, 2023): @patrickchugh I'd love helping to dig deeper into this, but the tf code is ~6k lines, ~250 resources, multiple times calling sub-modules, with resource names and filenames pointing to the name of our customer, the software they're using etc. I can't even exactly identify in which module it's hanging. terravision is processing ```aws_ecs_service._``` but that's a resource being created in 6 different module invocations and I don't see which invocation is the affected one. If I'd knew which one it is, I'd clean up the relevant terraform parts from customer references/sensitive data and supply them.

BreizhHardware commented

2026-05-06 12:36:20 +02:00

Author

Owner

@patrickchugh commented on GitHub (Aug 27, 2023):

@bengels00 let me work on a fix that tells you the offending line and resources. Will get back to you soon

@patrickchugh commented on GitHub (Aug 27, 2023): @bengels00 let me work on a fix that tells you the offending line and resources. Will get back to you soon

BreizhHardware referenced this issue

2026-05-06 12:37:45 +02:00

[PR #23] [CLOSED] fix #22 #129