[PR #144] [MERGED] Implement #17 #18 #273

New issue

Closed

opened 2026-05-07 00:20:07 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:20:07 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/144
Author: @speed47
Created: 2/18/2021
Status: ✅ Merged
Merged: 2/22/2021
Merged by: @speed47

Base: master ← Head: guests

📝 Commits (5)

2f0002a enh: groupAddServer: augment the returned JSON with the added server details
4b45887 fix: groupDelGuestAccess: deleting a guest access returned an error on TTL-forced groups
d886b48 enh: guests: groupAddGuestAccess now supports setting a comment
71605a1 feat: auto-add hostname as comment in groupAddServer / selfAddPersonalAccesss
4c846e2 chore: update generated doc

📊 Changes

13 files changed (+128 additions, -74 deletions)

View changed files

📝 bin/helper/osh-accountAddGroupServer (+3 -1)
📝 bin/helper/osh-accountModifyPersonalAccess (+18 -0)
📝 bin/helper/osh-groupAddServer (+5 -1)
📝 bin/plugin/group-aclkeeper/groupAddServer (+6 -0)
📝 bin/plugin/group-gatekeeper/groupAddGuestAccess (+6 -2)
📝 bin/plugin/restricted/selfAddPersonalAccess (+6 -0)
📝 doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst (+7 -2)
📝 lib/perl/OVH/Bastion.pm (+2 -1)
📝 lib/perl/OVH/Bastion/Plugin/groupSetRole.pm (+29 -21)
📝 lib/perl/OVH/Bastion/allowdeny.inc (+15 -12)
📝 lib/perl/OVH/Bastion/allowkeeper.inc (+3 -7)
📝 tests/functional/tests.d/340-selfaccesses.sh (+15 -14)
📝 tests/functional/tests.d/350-groups.sh (+13 -13)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/144 **Author:** [@speed47](https://github.com/speed47) **Created:** 2/18/2021 **Status:** ✅ Merged **Merged:** 2/22/2021 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `guests` --- ### 📝 Commits (5) - [`2f0002a`](https://github.com/ovh/the-bastion/commit/2f0002aed74064fcd4bcaba5156e68d67fc80b9d) enh: groupAddServer: augment the returned JSON with the added server details - [`4b45887`](https://github.com/ovh/the-bastion/commit/4b4588736b00254a4f1cd78a50e9eb42cfac6935) fix: groupDelGuestAccess: deleting a guest access returned an error on TTL-forced groups - [`d886b48`](https://github.com/ovh/the-bastion/commit/d886b48d60edddf820ea64d1ce791819d4655fa2) enh: guests: groupAddGuestAccess now supports setting a comment - [`71605a1`](https://github.com/ovh/the-bastion/commit/71605a1cff863e90863816cd0774357fb8643002) feat: auto-add hostname as comment in groupAddServer / selfAddPersonalAccesss - [`4c846e2`](https://github.com/ovh/the-bastion/commit/4c846e21e3b64d3b3f072e8d910c86ae8042702b) chore: update generated doc ### 📊 Changes **13 files changed** (+128 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `bin/helper/osh-accountAddGroupServer` (+3 -1) 📝 `bin/helper/osh-accountModifyPersonalAccess` (+18 -0) 📝 `bin/helper/osh-groupAddServer` (+5 -1) 📝 `bin/plugin/group-aclkeeper/groupAddServer` (+6 -0) 📝 `bin/plugin/group-gatekeeper/groupAddGuestAccess` (+6 -2) 📝 `bin/plugin/restricted/selfAddPersonalAccess` (+6 -0) 📝 `doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst` (+7 -2) 📝 `lib/perl/OVH/Bastion.pm` (+2 -1) 📝 `lib/perl/OVH/Bastion/Plugin/groupSetRole.pm` (+29 -21) 📝 `lib/perl/OVH/Bastion/allowdeny.inc` (+15 -12) 📝 `lib/perl/OVH/Bastion/allowkeeper.inc` (+3 -7) 📝 `tests/functional/tests.d/340-selfaccesses.sh` (+15 -14) 📝 `tests/functional/tests.d/350-groups.sh` (+13 -13) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>