[PR #195] [MERGED] Tests framework refactoring and drop support/tests for EOL OSes #306

New issue

Closed

opened 2026-05-07 00:20:17 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:20:17 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/195
Author: @speed47
Created: 6/7/2021
Status: ✅ Merged
Merged: 6/25/2021
Merged by: @speed47

Base: master ← Head: tests

📝 Commits (2)

2f4ce13 support: del deb8/ubuntu1404/opensuse150/opensuse151, add opensuse153
0d2300b enh: tests: refactor the framework for more maintainability

📊 Changes

33 files changed (+234 additions, -285 deletions)

View changed files

📝 .github/workflows/freebsd.yml (+4 -4)
📝 .github/workflows/tests.yml (+17 -3)
📝 README.md (+5 -7)
📝 bin/admin/fixrights.sh (+0 -1)
➖ contrib/libterm-readline-gnu-perl-jessiefix.patch (+0 -14)
📝 doc/sphinx/installation/advanced.rst (+0 -13)
📝 doc/sphinx/installation/basic.rst (+5 -7)
📝 docker/Dockerfile.centos7 (+2 -2)
📝 docker/Dockerfile.centos8 (+2 -2)
📝 docker/Dockerfile.debian10 (+2 -2)
📝 docker/Dockerfile.debian11 (+2 -2)
➖ docker/Dockerfile.debian8 (+0 -30)
📝 docker/Dockerfile.debian9 (+2 -2)
📝 docker/Dockerfile.opensuse15 (+4 -3)
➖ docker/Dockerfile.opensuse150 (+0 -27)
➖ docker/Dockerfile.opensuse151 (+0 -27)
📝 docker/Dockerfile.sandbox (+1 -1)
➖ docker/Dockerfile.ubuntu1404 (+0 -30)
📝 docker/Dockerfile.ubuntu1604 (+2 -2)
📝 docker/Dockerfile.ubuntu1804 (+2 -2)

...and 13 more files

📄 Description

The chain of executions is as is:

docker_build_and_run_tests_all.sh
- launches several instances of docker_build_and_run_tests.sh
  - builds docker images with the target_role.sh and tester_role.sh entrypoints
    - inside the tester docker, tester_role.sh launches launch_tests_on_instance.sh
    - the target docker gets tested after setting up accounts, SSH etc.

Previously, these scripts passed options to each other either by a mix of environment
variables and command-line arguments, with some inconsistencies here and there.

Now, launch_tests_on_instance.sh supports a lot of command-line options, which can
be specified directly if testing a remote server, or can be passed-through by the calling
script in case of docker tests. docker_build_and_run_tests.sh and
docker_build_and_run_tests_all.sh also support to passthrough these options down.

Remove support for EOL OSes:

Debian 8
Ubuntu 14.04
OpenSUSE 15.0
OpenSUSE 15.1

Add support for:

OpenSUSE 15.3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/195 **Author:** [@speed47](https://github.com/speed47) **Created:** 6/7/2021 **Status:** ✅ Merged **Merged:** 6/25/2021 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `tests` --- ### 📝 Commits (2) - [`2f4ce13`](https://github.com/ovh/the-bastion/commit/2f4ce13b3fc654b0902a3eab2b042944872d91ce) support: del deb8/ubuntu1404/opensuse150/opensuse151, add opensuse153 - [`0d2300b`](https://github.com/ovh/the-bastion/commit/0d2300b82516a3c3cdd2a166451eff1c80ca8f26) enh: tests: refactor the framework for more maintainability ### 📊 Changes **33 files changed** (+234 additions, -285 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/freebsd.yml` (+4 -4) 📝 `.github/workflows/tests.yml` (+17 -3) 📝 `README.md` (+5 -7) 📝 `bin/admin/fixrights.sh` (+0 -1) ➖ `contrib/libterm-readline-gnu-perl-jessiefix.patch` (+0 -14) 📝 `doc/sphinx/installation/advanced.rst` (+0 -13) 📝 `doc/sphinx/installation/basic.rst` (+5 -7) 📝 `docker/Dockerfile.centos7` (+2 -2) 📝 `docker/Dockerfile.centos8` (+2 -2) 📝 `docker/Dockerfile.debian10` (+2 -2) 📝 `docker/Dockerfile.debian11` (+2 -2) ➖ `docker/Dockerfile.debian8` (+0 -30) 📝 `docker/Dockerfile.debian9` (+2 -2) 📝 `docker/Dockerfile.opensuse15` (+4 -3) ➖ `docker/Dockerfile.opensuse150` (+0 -27) ➖ `docker/Dockerfile.opensuse151` (+0 -27) 📝 `docker/Dockerfile.sandbox` (+1 -1) ➖ `docker/Dockerfile.ubuntu1404` (+0 -30) 📝 `docker/Dockerfile.ubuntu1604` (+2 -2) 📝 `docker/Dockerfile.ubuntu1804` (+2 -2) _...and 13 more files_ </details> ### 📄 Description The chain of executions is as is: - `docker_build_and_run_tests_all.sh` - launches several instances of `docker_build_and_run_tests.sh` - builds docker images with the `target_role.sh` and `tester_role.sh` entrypoints - inside the tester docker, `tester_role.sh` launches `launch_tests_on_instance.sh` - the target docker gets tested after setting up accounts, SSH etc. Previously, these scripts passed options to each other either by a mix of environment variables and command-line arguments, with some inconsistencies here and there. Now, `launch_tests_on_instance.sh` supports a lot of command-line options, which can be specified directly if testing a remote server, or can be passed-through by the calling script in case of docker tests. `docker_build_and_run_tests.sh` and `docker_build_and_run_tests_all.sh` also support to passthrough these options down. Remove support for EOL OSes: - Debian 8 - Ubuntu 14.04 - OpenSUSE 15.0 - OpenSUSE 15.1 Add support for: - OpenSUSE 15.3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>