[PR #347] [MERGED] fix: rare race condition introduced by `b7f4909` #418

New issue

Closed

opened 2026-05-07 00:20:49 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:20:49 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/347
Author: @speed47
Created: 10/27/2022
Status: ✅ Merged
Merged: 11/15/2022
Merged by: @speed47

Base: master ← Head: fixexecute

📝 Commits (1)

9fe8611 fix: rare race condition introduced by b7f4909

📊 Changes

3 files changed (+181 additions, -74 deletions)

View changed files

📝 bin/plugin/open/scp (+4 -10)
📝 lib/perl/OVH/Bastion/execute.inc (+176 -64)
📝 tests/functional/tests.d/330-selfkeys.sh (+1 -0)

📄 Description

Under some specific conditions, the execute() call could get deadlocked with the program it started, both waiting for each other to read or write data. This is easier to reproduce with the scp plugin, where the transfer would just stall. Introduce an additional intermediate buffer to avoid this race condition.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/347 **Author:** [@speed47](https://github.com/speed47) **Created:** 10/27/2022 **Status:** ✅ Merged **Merged:** 11/15/2022 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `fixexecute` --- ### 📝 Commits (1) - [`9fe8611`](https://github.com/ovh/the-bastion/commit/9fe8611a73207120afcde4072d303dc179774c71) fix: rare race condition introduced by b7f4909 ### 📊 Changes **3 files changed** (+181 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `bin/plugin/open/scp` (+4 -10) 📝 `lib/perl/OVH/Bastion/execute.inc` (+176 -64) 📝 `tests/functional/tests.d/330-selfkeys.sh` (+1 -0) </details> ### 📄 Description Under some specific conditions, the execute() call could get deadlocked with the program it started, both waiting for each other to read or write data. This is easier to reproduce with the `scp` plugin, where the transfer would just stall. Introduce an additional intermediate buffer to avoid this race condition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>