[PR #409] [MERGED] enh: setup-gpg.sh: create additional backup signing config with --generate #458

New issue

Closed

opened 2026-05-07 00:21:00 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:00 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/409
Author: @docwalter
Created: 8/9/2023
Status: ✅ Merged
Merged: 8/22/2023
Merged by: @speed47

Base: master ← Head: sign-backups

📝 Commits (1)

0d726eb enh: setup-gpg.sh: create additional backup signing config with --generate

📊 Changes

1 file changed (+25 additions, -0 deletions)

View changed files

📝 bin/admin/setup-gpg.sh (+25 -0)

📄 Description

#243 allows for signed backups, but setup-gpg.sh --generate only creates signing config for session recording backups so far. With this code, setup-gpg.sh generates a config snippet for signing configuration backups, too.

Since the signing key passphrase can contain arbitrary special characters, it is wrapped in single quotes and any contained single quote ' is escaped as '\''. Tested it successfully with a several generated signing key passphrases, including ones with single quotes.

Signed-off-by: Philipp Walter p.walter@infoserve.de

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/409 **Author:** [@docwalter](https://github.com/docwalter) **Created:** 8/9/2023 **Status:** ✅ Merged **Merged:** 8/22/2023 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `sign-backups` --- ### 📝 Commits (1) - [`0d726eb`](https://github.com/ovh/the-bastion/commit/0d726ebbce17cb4ad42bf3cf43cb356513ebd66a) enh: setup-gpg.sh: create additional backup signing config with --generate ### 📊 Changes **1 file changed** (+25 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `bin/admin/setup-gpg.sh` (+25 -0) </details> ### 📄 Description #243 allows for signed backups, but `setup-gpg.sh --generate` only creates signing config for session recording backups so far. With this code, setup-gpg.sh generates a config snippet for signing configuration backups, too. Since the signing key passphrase can contain arbitrary special characters, it is wrapped in single quotes and any contained single quote `'` is escaped as `'\''`. Tested it successfully with a several generated signing key passphrases, including ones with single quotes. Signed-off-by: Philipp Walter <p.walter@infoserve.de> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>