[PR #417] [MERGED] fix: setup-gpg.sh: in some cases, an invalid configuration file could… #466

New issue

Closed

opened 2026-05-07 00:21:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/417
Author: @speed47
Created: 9/20/2023
Status: ✅ Merged
Merged: 9/20/2023
Merged by: @speed47

Base: master ← Head: fixgpg

📝 Commits (1)

bd5b921 fix: setup-gpg.sh: in some cases, an invalid configuration file could be generated

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 bin/admin/setup-gpg.sh (+2 -2)

📄 Description

… be generated

The escape code didn't work correctly, remove it as it's not needed, indeed we already ensure that the generated password doesn't contain any " or , hence surrounding the var by "" quotes is enough.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/417 **Author:** [@speed47](https://github.com/speed47) **Created:** 9/20/2023 **Status:** ✅ Merged **Merged:** 9/20/2023 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `fixgpg` --- ### 📝 Commits (1) - [`bd5b921`](https://github.com/ovh/the-bastion/commit/bd5b92163fb12947c1c2267572f7b5866ddf1a09) fix: setup-gpg.sh: in some cases, an invalid configuration file could be generated ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/admin/setup-gpg.sh` (+2 -2) </details> ### 📄 Description … be generated The escape code didn't work correctly, remove it as it's not needed, indeed we already ensure that the generated password doesn't contain any " or \, hence surrounding the var by "" quotes is enough. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>