[PR #420] [CLOSED] Implement Ingress Secure Keys #467

New issue

Closed

opened 2026-05-07 00:21:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/420
Author: @P-EB
Created: 9/25/2023
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (4)

54d12c7 Implement Ingress Secure Keys
5af7e55 Escape dots in regex patterns for ssh algorithms
b9b4899 Factor out in a generic function the helper listing allowed ssh key algorithm
72be788 Drop an unused variable in print_accepted_key_algorithms

📊 Changes

6 files changed (+38 additions, -34 deletions)

View changed files

📝 bin/plugin/open/selfAddIngressKey (+1 -14)
📝 bin/plugin/restricted/accountCreate (+1 -13)
📝 etc/bastion/bastion.conf.dist (+1 -1)
📝 lib/perl/OVH/Bastion.pm (+1 -1)
📝 lib/perl/OVH/Bastion/configuration.inc (+2 -2)
📝 lib/perl/OVH/Bastion/ssh.inc (+32 -3)

📄 Description

This is a draft lacking unit/functional tests.

I'd like to get your feeling about including SecureKeys.

Regarding testing, I'd be happy to write the tests but I'm not sure to have understood the code flow and style in 330-selfkeys.sh.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/420 **Author:** [@P-EB](https://github.com/P-EB) **Created:** 9/25/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`54d12c7`](https://github.com/ovh/the-bastion/commit/54d12c7816a74920882e3e5d919efbeb03724e9c) Implement Ingress Secure Keys - [`5af7e55`](https://github.com/ovh/the-bastion/commit/5af7e5504376bb2490135771e1f2ddcb0f797097) Escape dots in regex patterns for ssh algorithms - [`b9b4899`](https://github.com/ovh/the-bastion/commit/b9b489962893f585e2bdea4e348077102c77a2ea) Factor out in a generic function the helper listing allowed ssh key algorithm - [`72be788`](https://github.com/ovh/the-bastion/commit/72be788748bc08734f83148d565986364605dfe6) Drop an unused variable in print_accepted_key_algorithms ### 📊 Changes **6 files changed** (+38 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `bin/plugin/open/selfAddIngressKey` (+1 -14) 📝 `bin/plugin/restricted/accountCreate` (+1 -13) 📝 `etc/bastion/bastion.conf.dist` (+1 -1) 📝 `lib/perl/OVH/Bastion.pm` (+1 -1) 📝 `lib/perl/OVH/Bastion/configuration.inc` (+2 -2) 📝 `lib/perl/OVH/Bastion/ssh.inc` (+32 -3) </details> ### 📄 Description This is a draft lacking unit/functional tests. I'd like to get your feeling about including SecureKeys. Regarding testing, I'd be happy to write the tests but I'm not sure to have understood the code flow and style in `330-selfkeys.sh`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>