[PR #421] [MERGED] Allow setup-gpg.sh --import to receive, trust, and add to configure multiple public keys at once #469

New issue

Closed

opened 2026-05-07 00:21:04 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:04 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/421
Author: @P-EB
Created: 9/29/2023
Status: ✅ Merged
Merged: 10/27/2023
Merged by: @speed47

Base: master ← Head: feature/handle_multiple_admin_keys

📝 Commits (2)

d9431b6 Allow setup-gpg.sh --import to receive, trust, and add to configure multiple public keys at once
6ff1990 enh: add tests for multiple gpg keys setup

📊 Changes

4 files changed (+118 additions, -14 deletions)

View changed files

📝 bin/admin/setup-gpg.sh (+18 -14)
📝 lib/shell/functions.inc (+9 -0)
📝 tests/functional/launch_tests_on_instance.sh (+62 -0)
📝 tests/functional/tests.d/200-scripts.sh (+29 -0)

📄 Description

Hello,

While the whole bastion logic seems to allow for multiple admin keys, the import system doesn't allow for it as it only keeps the latest added key, only trusts this one and then add it to the rsync/backup configurations (and refuses to run more than once as soon as these configurations exist).

While it's not perfect as it doesn't handle the multiple layers considered in the rsync system, this patch should give bastion users plenty more flexibility to handle admin keys addition.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/421 **Author:** [@P-EB](https://github.com/P-EB) **Created:** 9/29/2023 **Status:** ✅ Merged **Merged:** 10/27/2023 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `feature/handle_multiple_admin_keys` --- ### 📝 Commits (2) - [`d9431b6`](https://github.com/ovh/the-bastion/commit/d9431b6b7d28bdec3aaed4a31069d9f01da3dfde) Allow setup-gpg.sh --import to receive, trust, and add to configure multiple public keys at once - [`6ff1990`](https://github.com/ovh/the-bastion/commit/6ff19906545e63298023e391dba2162b51fc2254) enh: add tests for multiple gpg keys setup ### 📊 Changes **4 files changed** (+118 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `bin/admin/setup-gpg.sh` (+18 -14) 📝 `lib/shell/functions.inc` (+9 -0) 📝 `tests/functional/launch_tests_on_instance.sh` (+62 -0) 📝 `tests/functional/tests.d/200-scripts.sh` (+29 -0) </details> ### 📄 Description Hello, While the whole bastion logic seems to allow for multiple admin keys, the import system doesn't allow for it as it only keeps the latest added key, only trusts this one and then add it to the rsync/backup configurations (and refuses to run more than once as soon as these configurations exist). While it's not perfect as it doesn't handle the multiple layers considered in the rsync system, this patch should give bastion users plenty more flexibility to handle admin keys addition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>