[PR #432] [CLOSED] enh: 35% faster is_valid_ip #478

New issue

Closed

opened 2026-05-07 00:21:06 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:06 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/432
Author: @speed47
Created: 11/13/2023
Status: ❌ Closed

Base: master ← Head: is_valid_ip

📝 Commits (10+)

f5f0cdf chore: faster tests by removing grant/revoke command dance
288ff63 chore: tests: no longer run consistency check by default
7c42c78 chg: set ECDSA as default egress key algo for new installs
f30cec2 fix: accountInfo: don't attempt (and fail) to display info non-auditors don't have access to
49f8407 fix: groupInfo: don't attempt to (and fail) display the guest list when account doesn't have access to it
292ed30 enh: accountInfo: add osh-only information for accounts
6b9e622 chg: groupInfo: remove deprecated JSON fields
a97db44 chore: factorize user@host:port display in machine_display()
223713c feat: IPv6 support
a0414e8 enh: 35% faster is_valid_ip() when fast=1

📊 Changes

38 files changed (+1296 additions, -630 deletions)

View changed files

📝 .github/workflows/freebsd.yml (+0 -1)
📝 .github/workflows/tests.yml (+6 -6)
📝 bin/helper/osh-accountModifyPersonalAccess (+1 -3)
📝 bin/helper/osh-groupAddServer (+1 -3)
📝 bin/plugin/open/groupInfo (+8 -12)
📝 bin/plugin/restricted/accountInfo (+94 -70)
📝 bin/shell/osh.pl (+13 -8)
📝 doc/sphinx/administration/configuration/bastion_conf.rst (+26 -2)
📝 doc/sphinx/development/setup.rst (+1 -1)
📝 etc/bastion/bastion.conf.dist (+14 -4)
📝 lib/perl/OVH/Bastion.pm (+58 -43)
📝 lib/perl/OVH/Bastion/Plugin/groupSetRole.pm (+7 -7)
📝 lib/perl/OVH/Bastion/Plugin/otherProtocol.pm (+1 -1)
📝 lib/perl/OVH/Bastion/allowdeny.inc (+25 -17)
📝 lib/perl/OVH/Bastion/allowkeeper.inc (+2 -6)
📝 lib/perl/OVH/Bastion/configuration.inc (+3 -3)
📝 tests/functional/docker/docker_build_and_run_tests.sh (+7 -1)
📝 tests/functional/docker/target_role.sh (+2 -3)
📝 tests/functional/launch_tests_on_instance.sh (+16 -16)
📝 tests/functional/tests.d/200-scripts.sh (+0 -11)

...and 18 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/432 **Author:** [@speed47](https://github.com/speed47) **Created:** 11/13/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `is_valid_ip` --- ### 📝 Commits (10+) - [`f5f0cdf`](https://github.com/ovh/the-bastion/commit/f5f0cdfba4b166fa59015f573f4dac4c8971760a) chore: faster tests by removing grant/revoke command dance - [`288ff63`](https://github.com/ovh/the-bastion/commit/288ff637d9037ebe118261fad6ccfc661659bcff) chore: tests: no longer run consistency check by default - [`7c42c78`](https://github.com/ovh/the-bastion/commit/7c42c78d8020935e4b5438cfd2cb27a6cf8d83d4) chg: set ECDSA as default egress key algo for new installs - [`f30cec2`](https://github.com/ovh/the-bastion/commit/f30cec2f296abfd5a077eb61fa91a91ce0d7e31e) fix: accountInfo: don't attempt (and fail) to display info non-auditors don't have access to - [`49f8407`](https://github.com/ovh/the-bastion/commit/49f840779d5ffaccabdb477b1054d3f0054c970a) fix: groupInfo: don't attempt to (and fail) display the guest list when account doesn't have access to it - [`292ed30`](https://github.com/ovh/the-bastion/commit/292ed300c45329436197339d10e8d5dd6a83539b) enh: accountInfo: add osh-only information for accounts - [`6b9e622`](https://github.com/ovh/the-bastion/commit/6b9e62297e1ccbedb973892e22fe1065165835f3) chg: groupInfo: remove deprecated JSON fields - [`a97db44`](https://github.com/ovh/the-bastion/commit/a97db44206b1f8b923f9d2428390b0d65c6f7bdc) chore: factorize user@host:port display in machine_display() - [`223713c`](https://github.com/ovh/the-bastion/commit/223713c7e80cf63f1e7e001cb9f1ba7b307e4f5b) feat: IPv6 support - [`a0414e8`](https://github.com/ovh/the-bastion/commit/a0414e843daea484e0ed7140612022502803cbf9) enh: 35% faster is_valid_ip() when fast=1 ### 📊 Changes **38 files changed** (+1296 additions, -630 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/freebsd.yml` (+0 -1) 📝 `.github/workflows/tests.yml` (+6 -6) 📝 `bin/helper/osh-accountModifyPersonalAccess` (+1 -3) 📝 `bin/helper/osh-groupAddServer` (+1 -3) 📝 `bin/plugin/open/groupInfo` (+8 -12) 📝 `bin/plugin/restricted/accountInfo` (+94 -70) 📝 `bin/shell/osh.pl` (+13 -8) 📝 `doc/sphinx/administration/configuration/bastion_conf.rst` (+26 -2) 📝 `doc/sphinx/development/setup.rst` (+1 -1) 📝 `etc/bastion/bastion.conf.dist` (+14 -4) 📝 `lib/perl/OVH/Bastion.pm` (+58 -43) 📝 `lib/perl/OVH/Bastion/Plugin/groupSetRole.pm` (+7 -7) 📝 `lib/perl/OVH/Bastion/Plugin/otherProtocol.pm` (+1 -1) 📝 `lib/perl/OVH/Bastion/allowdeny.inc` (+25 -17) 📝 `lib/perl/OVH/Bastion/allowkeeper.inc` (+2 -6) 📝 `lib/perl/OVH/Bastion/configuration.inc` (+3 -3) 📝 `tests/functional/docker/docker_build_and_run_tests.sh` (+7 -1) 📝 `tests/functional/docker/target_role.sh` (+2 -3) 📝 `tests/functional/launch_tests_on_instance.sh` (+16 -16) 📝 `tests/functional/tests.d/200-scripts.sh` (+0 -11) _...and 18 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>